Date: Thu, 7 Mar 2019 09:32:38 -0800 From: Yuri <yuri@freebsd.org> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r494857 - in head/multimedia/webcamoid: . files Message-ID: <73df7274-1866-1f9f-3b4b-bc74eacff8e2@freebsd.org> In-Reply-To: <alpine.LSU.2.21.1903072009030.4540@anthias.pfeifer.com> References: <201903062230.x26MUo8W039525@repo.freebsd.org> <alpine.LSU.2.21.1903072009030.4540@anthias.pfeifer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/7/19 4:11 AM, Gerald Pfeifer wrote:
> This is a little short of a commit log given all the changes to the
> port in this commit. Such as...
>
>> -USES= pkgconfig qmake qt:5
>> +USES= gl gnome pkgconfig qmake qt:5
> ...this
>
>> -# Workaround for the crash when built with clang that the upstream author says is a bug in clang
>> -USE_GCC= yes
> ...or this. Plus, with USE_GCC being removed...
These two are mundane or self-explanatory, though. "gl gnome" are now
required, and workaround isn't needed since the problem is gone.
Somebody said before that any idiot can read diffs, no need to repeat
them in words. -)
>> # Workaround for Bug#224137: devel/qt5-qmake: Doesn't use the right compiler in case USE_GCC is selected
>> BINARY_ALIAS= g++=${CXX}
> ...this cannot be right any longer. Or at a minimum the comment
> referring to USE_GCC cannot be?
There are some architectures that use gcc as a default compiler, so this
line is relevant, but it could use if/endif block conditioned on gcc
being a compiler.
I will add this, and related notes to the port.
Thank you for your comments, I will try to write mode detailed logs.
Yuri
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?73df7274-1866-1f9f-3b4b-bc74eacff8e2>