From owner-cvs-src@FreeBSD.ORG Tue Mar 4 16:15:49 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A2317106566C; Tue, 4 Mar 2008 16:15:49 +0000 (UTC) (envelope-from Hartmut.Brandt@dlr.de) Received: from smtp-1.dlr.de (smtp-1.dlr.de [195.37.61.185]) by mx1.freebsd.org (Postfix) with ESMTP id 368BB8FC2A; Tue, 4 Mar 2008 16:15:48 +0000 (UTC) (envelope-from Hartmut.Brandt@dlr.de) Received: from knop-beagle.kn.op.dlr.de ([129.247.173.6]) by smtp-1.dlr.de over TLS secured channel with Microsoft SMTPSVC(6.0.3790.1830); Tue, 4 Mar 2008 17:15:19 +0100 Date: Tue, 4 Mar 2008 17:15:21 +0100 (CET) From: Harti Brandt X-X-Sender: brandt_h@knop-beagle.kn.op.dlr.de To: Warner Losh In-Reply-To: <200803041556.m24FuIqw012139@repoman.freebsd.org> Message-ID: <20080304171410.V893@knop-beagle.kn.op.dlr.de> References: <200803041556.m24FuIqw012139@repoman.freebsd.org> X-OpenPGP-Key: harti@freebsd.org MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-OriginalArrivalTime: 04 Mar 2008 16:15:19.0180 (UTC) FILETIME=[F0A33CC0:01C87E12] Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/make arch.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Harti Brandt List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Mar 2008 16:15:49 -0000 On Tue, 4 Mar 2008, Warner Losh wrote: WL>imp 2008-03-04 15:56:18 UTC WL> WL> FreeBSD src repository WL> WL> Modified files: WL> usr.bin/make arch.c WL> Log: WL> is necessary for using INT_MIN, so included it here WL> explicitly rather than relying on name space pollution to pull it in WL> for us. WL> WL> NB: The usage of INT_MIN is somewhat bogus and suspect to my eye, but this WL> commit doesn't address that issue. Yes. This looks like a bug. ArchStatMember returns INT64_MIN if it cannot stat the archive member. So the caller must check for INT64_MIN. harti