From owner-cvs-src@FreeBSD.ORG Sat Jul 9 04:00:35 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E8E6816A41F; Sat, 9 Jul 2005 04:00:35 +0000 (GMT) (envelope-from sobomax@web.portaone.com) Received: from www.portaone.com (support.portaone.com [195.70.151.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9BC8943D46; Sat, 9 Jul 2005 04:00:30 +0000 (GMT) (envelope-from sobomax@web.portaone.com) Received: from www.portaone.com (localhost [127.0.0.1]) by www.portaone.com (8.12.11/8.12.11) with ESMTP id j6940T99070598 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 9 Jul 2005 06:00:29 +0200 (CEST) (envelope-from sobomax@web.portaone.com) Received: (from sobomax@localhost) by www.portaone.com (8.12.11/8.12.11/Submit) id j6940Tal070597; Sat, 9 Jul 2005 06:00:29 +0200 (CEST) (envelope-from sobomax) Date: Sat, 9 Jul 2005 06:00:29 +0200 From: Maxim Sobolev To: Scott Long Message-ID: <20050709040029.GB64401@www.portaone.com> References: <200507081837.j68Ib0IM082223@repoman.freebsd.org> <42CECCD8.5070201@portaone.com> <42CEEF12.4070904@samsco.org> <20050709033317.GA64401@www.portaone.com> <42CF4672.2090204@samsco.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42CF4672.2090204@samsco.org> User-Agent: Mutt/1.5.8i X-Virus-Scanned: ClamAV 0.83/974/Fri Jul 8 23:09:18 2005 on www.portaone.com X-Virus-Status: Clean Cc: Roman Kurakin , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/ndis subr_ntoskrnl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jul 2005 04:00:36 -0000 On Fri, Jul 08, 2005 at 09:37:22PM -0600, Scott Long wrote: > Maxim Sobolev wrote: > >On Fri, Jul 08, 2005 at 03:24:34PM -0600, Scott Long wrote: > > > >>>I think the better fix is to change type of k_lock member from void* to > >>>the struct mtx*, I've already commited such change to the RELENG_5 few > >>>days ago. > >>> > >>>-Maxim > >> > >>It's a void* for portability with other OS's. This work has already > >>been ported > >>to Solaris, and maybe even other OS's by now. Reducing the portability > >>is a > >>bad idea, and will likely get you smacked around by Bill when he > >>notices. I'd > >>highly recommend not doing this again in the future. > > > > > >Even if so, rik's version is no better since it adds explicit cast > >(two of them in fact) to struct mtx*. Either way it will break > >portability with other OSes. Therefore, they are on par, but my > >solution is more clear wrt FreeBSD. > > > >-Maxim > > subr_ntoskrnl.c explicitely uses the FreeBSD mtx API, so adding FreeBSD > casts is fine. Polluting the common headers, as you did, is not the > same thing. OK, you are right. -Maxim