From owner-freebsd-stable@FreeBSD.ORG Tue Jan 29 19:08:12 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id C836F1F8; Tue, 29 Jan 2013 19:08:12 +0000 (UTC) (envelope-from mike@sentex.net) Received: from smarthost1.sentex.ca (smarthost1-6.sentex.ca [IPv6:2607:f3e0:0:1::12]) by mx1.freebsd.org (Postfix) with ESMTP id 934B8D4; Tue, 29 Jan 2013 19:08:12 +0000 (UTC) Received: from [192.168.43.26] (pyroxene.sentex.ca [199.212.134.18]) by smarthost1.sentex.ca (8.14.5/8.14.5) with ESMTP id r0TJ8BFW045503; Tue, 29 Jan 2013 14:08:11 -0500 (EST) (envelope-from mike@sentex.net) Message-ID: <51081E18.60303@sentex.net> Date: Tue, 29 Jan 2013 14:08:08 -0500 From: Mike Tancsa Organization: Sentex Communications User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Kimmo Paasiala Subject: Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9 References: <50F6D20A.6070306@FreeBSD.org> <20130117001116.GD29437@lor.one-eyed-alien.net> <50F81588.5020106@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 1.4.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.72 on 64.7.153.18 Cc: freebsd-stable@freebsd.org, Brooks Davis , Dimitry Andric X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jan 2013 19:08:12 -0000 On 1/17/2013 4:35 PM, Kimmo Paasiala wrote: > On Thu, Jan 17, 2013 at 5:15 PM, Dimitry Andric wrote: >> On 2013-01-17 14:07, Kimmo Paasiala wrote: >>> >>> On Thu, Jan 17, 2013 at 2:11 AM, Brooks Davis wrote: >> >> ... >> >> Please try the following patch, which tells configure that HAVE_STRNVIS >> is always false. I think this is the easiest way, unless we really want >> the port to use our own strnvis. > > This will still leave the exported symbol in the plugin binary with > the name strnvis. What would be needed is renaming of the function to > something else, like pam_ssh_agent_auth_strnvis(), maybe using a macro > > #define strnvis pam_ssh_agent_auth_strnvis > > somewhere. > > I can try my hand on coming up with a fix but its going to take some > time, the source code of the plugin and not to mention the configure > script look quite hairy. Hi, Just wondering if anyone ever came up with a patch / work around to this ? ---Mike -- ------------------- Mike Tancsa, tel +1 519 651 3400 Sentex Communications, mike@sentex.net Providing Internet services since 1994 www.sentex.net Cambridge, Ontario Canada http://www.tancsa.com/