Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 29 Aug 2018 11:26:51 +0200
From:      Michael Gmelin <freebsd@grem.de>
To:        Konstantin Belousov <kostikbel@gmail.com>
Cc:        John Baldwin <jhb@FreeBSD.org>, "freebsd-current@freebsd.org" <freebsd-current@freebsd.org>, Matthias Apitz <guru@unixarea.de>
Subject:   Re: Fatal trap 12: page fault on Acer Chromebook 720 (peppy)
Message-ID:  <20180829112651.333b877b@bsd64.grem.de>
In-Reply-To: <20180829112105.47124954@bsd64.grem.de>
References:  <20180820150904.GS2340@kib.kiev.ua> <57B6DC4C-16EE-4B7B-B691-CB79D8C40289@grem.de> <20180822154603.GW2340@kib.kiev.ua> <C8BC1622-4F47-4E56-A428-46DAC5CE71B4@grem.de> <20180822211528.GB2340@kib.kiev.ua> <1C7DACDC-36F2-4E65-8C75-7B7215BB6546@grem.de> <20180824195947.GG2340@kib.kiev.ua> <32F22868-92ED-4223-84B5-77E72C7DCF50@grem.de> <20180824203903.GJ2340@kib.kiev.ua> <3CE9AF7F-CD5B-4FE3-9BDA-7F25C7A7C0B9@grem.de> <20180826130435.GS2340@kib.kiev.ua> <20180829112105.47124954@bsd64.grem.de>

next in thread | previous in thread | raw e-mail | index | archive | help


On Wed, 29 Aug 2018 11:21:05 +0200
Michael Gmelin <freebsd@grem.de> wrote:

> On Sun, 26 Aug 2018 16:04:35 +0300
> Konstantin Belousov <kostikbel@gmail.com> wrote:
> 
> > On Sat, Aug 25, 2018 at 07:21:28PM +0200, Michael Gmelin wrote:  
> > > Now, with the patch applied correctly, the machine actually boots.
> > > 
> > > Before calling init_ops.mp_bootaddress in
> > > getmemsize (machdep.c), physmap looks like this:
> > > 
> > > physmap_idx: 8
> > > i mem atop
> > > 0 0x0 0x0
> > > 1 0x30000 0x30
> > > 2 0x40000 0x40
> > > 3 0x9e400 0x9e
> > > 4 0x100000 0x100
> > > 5 0xf00000 0xf00
> > > 6 0x1000000 0x1000
> > > 7 0x7bf7a000 0x7bf7a
> > > 8 0x100000000 0x100000
> > > 9 0x100600000 0x100600
> > > 10 0x0 0x0
> > > 
> > > With your patch, it looks like this now
> > > (after calling getmemsize)
> > > 
> > > 0 0x0 0x0
> > > 1 0x30000 0x30
> > > 2 0x40000 0x40
> > > 3 0x9e400 0x9e
> > > 4 0x100000 0x100
> > > 5 0xf00000 0xf00
> > > 6 0x1000000 0x1000
> > > 7 0x7bf77000 0x7bf77
> > > 8 0x100000000 0x100000
> > > 9 0x100600000 0x100600
> > > 10 0x0 0x0
> > > PAGETABLES is 0x7bf77000
> > > 
> > > So I guess this means that the gap is now at the last three pages
> > > of [0x1000, 0x7bf7a[.
> > > 
> > > If this is what was intended, I guess it's good, as the machine
> > > boots okay now.    
> > 
> > It triggered the new code to chomp at the end of the suitable range,
> > instead of the start. Anyway, to do that, it must evaluated the
> > start of the range as intersecting with the kernel text, which I
> > interpret as success.
> > 
> > I put a review with the change at D16907.
> >   
> > > 
> > > Sorry again for the extra roundtrip, the patched file was simply
> > > in the wrong path.    
> > 
> > No problem.  
> 
> Just to close the loop on this: This was fixed in r338858, thanks to
> kib@ for analyzing the problem and creating a patch and to jhb@ for
> reviewing it.
> 

The actual revision this was fixed in is r338356
(https://svnweb.freebsd.org/base?view=revision&revision=338356), I
tested r338358 (world+kernel) to verify the fix.

Best,
Michael

-- 
Michael Gmelin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180829112651.333b877b>