From owner-freebsd-rc@FreeBSD.ORG Thu Oct 15 07:20:23 2009 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4C06A1065670; Thu, 15 Oct 2009 07:20:23 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper-int.allbsd.org [IPv6:2001:2f0:104:e002::2]) by mx1.freebsd.org (Postfix) with ESMTP id CC20F8FC17; Thu, 15 Oct 2009 07:20:22 +0000 (UTC) Received: from delta.allbsd.org (p2046-ipbf1608funabasi.chiba.ocn.ne.jp [123.225.211.46]) (authenticated bits=128) by mail.allbsd.org (8.14.3/8.14.3) with ESMTP id n9F7K989087210; Thu, 15 Oct 2009 16:20:21 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (alph.allbsd.org [192.168.0.10]) (authenticated bits=0) by delta.allbsd.org (8.13.4/8.13.4) with ESMTP id n9F7K5T8090604; Thu, 15 Oct 2009 16:20:07 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Thu, 15 Oct 2009 16:19:39 +0900 (JST) Message-Id: <20091015.161939.200967153.hrs@allbsd.org> To: dougb@FreeBSD.org From: Hiroki Sato In-Reply-To: <4AD3A722.9060401@FreeBSD.org> References: <200910052011.n95KBXdS024044@svn.freebsd.org> <4AD3A722.9060401@FreeBSD.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.2.52 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Thu_Oct_15_16_19_39_2009_433)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.95.2 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.3 (mail.allbsd.org [133.31.130.32]); Thu, 15 Oct 2009 16:20:21 +0900 (JST) Cc: markm@FreeBSD.org, freebsd-rc@FreeBSD.org Subject: Re: svn commit: r197790 - head/etc X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2009 07:20:23 -0000 ----Security_Multipart(Thu_Oct_15_16_19_39_2009_433)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hi Doug, Doug Barton wrote in <4AD3A722.9060401@FreeBSD.org>: do> I think this is the wrong solution to the problem. In at least two do> cases (routed and route6d) where $command is not defined in the rc.d do> scripts this change is resulting in $command not being defined at all. do> do> If you look at the definition of the + parameter substitution this do> makes sense: do> do> ${parameter:+word} do> Use Alternate Value. If parameter is unset or null, null do> is substituted; otherwise, the expansion of word is do> substituted. do> do> I think that what you really wanted to do was: I am sorry for the delay. Your patch is reasonable to me. This problem was there for a while, so it should be fixed asap. I noticed there was something wrong about ${name}_program but it seems I mistakenly changed it (sorry...). Then I received a report "it does not work" so I just reverted it. IMO defining $command in rc.d scripts is not a good practice. "Always use ${name}_program and let load_rc_config() set the $command" would be consistent and useful to avoid this sort of problems. -- Hiroki ----Security_Multipart(Thu_Oct_15_16_19_39_2009_433)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkrWzQsACgkQTyzT2CeTzy29/wCgv1dMPJJswx6WCfaLMyQbw8jI EVwAoJPQ0IC03SMxZ5QnZJEHXWPFoXzI =+z5p -----END PGP SIGNATURE----- ----Security_Multipart(Thu_Oct_15_16_19_39_2009_433)----