Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 23 Jun 2018 00:51:31 +0200 (CEST)
From:      Gerald Pfeifer <gerald@pfeifer.com>
To:        Lars Engels <lme@FreeBSD.org>, Michael Danilov <mike.d.ft402@gmail.com>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org,  svn-ports-head@freebsd.org
Subject:   Re: svn commit: r472962 - head/net-mgmt/aircrack-ng
Message-ID:  <alpine.LSU.2.21.1806221205330.3747@anthias.pfeifer.com>
In-Reply-To: <201806210759.w5L7x2cJ042398@repo.freebsd.org>
References:  <201806210759.w5L7x2cJ042398@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi Lars and Michael,

On Thu, 21 Jun 2018, Lars Engels wrote:
>   - Set required GCC version to 6+, so that the default gcc version is chosen.
>   GCC isn't needed to successfully building the port, but according to upstream
>
>   PR:		228747
>   Submitted by:	Michael Danilov <mike.d.ft402@gmail.com>

> -USE_GCC=	7+
> +USE_GCC=	6+

in that case, the canonical way to state that is

  USE_GCC=	yes

which has the advantage that it'll do what you are aiming for,
without a need to adjust as the default version moves (or if
some user changes the default via Mk/bsd.default-versions.mk).

I'll be happy to make this change if you agree.

Gerald



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.21.1806221205330.3747>