Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 21 Sep 2008 06:24:21 GMT
From:      Andrew Thompson <thompsa@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 150191 for review
Message-ID:  <200809210624.m8L6OLBY009942@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=150191

Change 150191 by thompsa@thompsa_burger on 2008/09/21 06:23:27

	Re-run the sed script to remove the parenthesis from &(var) as it only
	converts the first match on the line.

Affected files ...

.. //depot/projects/usb/src/sys/dev/usb2/controller/ehci2.c#14 edit
.. //depot/projects/usb/src/sys/dev/usb2/controller/ehci2_pci.c#11 edit
.. //depot/projects/usb/src/sys/dev/usb2/controller/ohci2.c#13 edit
.. //depot/projects/usb/src/sys/dev/usb2/controller/ohci2_pci.c#9 edit
.. //depot/projects/usb/src/sys/dev/usb2/controller/uhci2.c#11 edit
.. //depot/projects/usb/src/sys/dev/usb2/controller/uhci2_pci.c#10 edit
.. //depot/projects/usb/src/sys/dev/usb2/controller/usb2_controller.c#12 edit
.. //depot/projects/usb/src/sys/dev/usb2/core/usb2_hub.c#17 edit
.. //depot/projects/usb/src/sys/dev/usb2/core/usb2_msctest.c#7 edit
.. //depot/projects/usb/src/sys/dev/usb2/core/usb2_transfer.c#27 edit
.. //depot/projects/usb/src/sys/dev/usb2/ethernet/if_aue2.c#9 edit
.. //depot/projects/usb/src/sys/dev/usb2/ethernet/if_axe2.c#9 edit
.. //depot/projects/usb/src/sys/dev/usb2/ethernet/if_cue2.c#9 edit
.. //depot/projects/usb/src/sys/dev/usb2/ethernet/if_kue2.c#9 edit
.. //depot/projects/usb/src/sys/dev/usb2/ethernet/if_rue2.c#9 edit
.. //depot/projects/usb/src/sys/dev/usb2/ethernet/if_udav2.c#9 edit
.. //depot/projects/usb/src/sys/dev/usb2/input/ukbd2.c#8 edit
.. //depot/projects/usb/src/sys/dev/usb2/serial/uark2.c#6 edit
.. //depot/projects/usb/src/sys/dev/usb2/serial/ubsa2.c#8 edit
.. //depot/projects/usb/src/sys/dev/usb2/serial/uchcom2.c#7 edit
.. //depot/projects/usb/src/sys/dev/usb2/serial/ucycom2.c#7 edit
.. //depot/projects/usb/src/sys/dev/usb2/serial/ufoma2.c#8 edit
.. //depot/projects/usb/src/sys/dev/usb2/serial/uftdi2.c#7 edit
.. //depot/projects/usb/src/sys/dev/usb2/serial/uipaq2.c#8 edit
.. //depot/projects/usb/src/sys/dev/usb2/serial/umct2.c#6 edit
.. //depot/projects/usb/src/sys/dev/usb2/serial/umodem2.c#8 edit
.. //depot/projects/usb/src/sys/dev/usb2/serial/umoscom2.c#7 edit
.. //depot/projects/usb/src/sys/dev/usb2/serial/uplcom2.c#8 edit
.. //depot/projects/usb/src/sys/dev/usb2/serial/uvisor2.c#7 edit
.. //depot/projects/usb/src/sys/dev/usb2/serial/uvscom2.c#7 edit
.. //depot/projects/usb/src/sys/dev/usb2/sound/uaudio2.c#13 edit
.. //depot/projects/usb/src/sys/dev/usb2/wlan/if_rum2.c#15 edit
.. //depot/projects/usb/src/sys/dev/usb2/wlan/if_ural2.c#15 edit
.. //depot/projects/usb/src/sys/dev/usb2/wlan/if_zyd2.c#16 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/usb2/controller/ehci2.c#14 (text+ko) ====

@@ -126,10 +126,10 @@
 	struct ehci_softc *sc = EHCI_BUS2SC(bus);
 	uint32_t i;
 
-	cb(bus, &sc->sc_hw.pframes_pc, &(sc->sc_hw.pframes_pg),
+	cb(bus, &sc->sc_hw.pframes_pc, &sc->sc_hw.pframes_pg,
 	    sizeof(uint32_t) * EHCI_FRAMELIST_COUNT, EHCI_FRAMELIST_ALIGN);
 
-	cb(bus, &sc->sc_hw.async_start_pc, &(sc->sc_hw.async_start_pg),
+	cb(bus, &sc->sc_hw.async_start_pc, &sc->sc_hw.async_start_pg,
 	    sizeof(ehci_qh_t), EHCI_QH_ALIGN);
 
 	for (i = 0; i != EHCI_VIRTUAL_FRAMELIST_COUNT; i++) {

==== //depot/projects/usb/src/sys/dev/usb2/controller/ehci2_pci.c#11 (text+ko) ====

@@ -337,7 +337,7 @@
 		sprintf(sc->sc_vendor, "(0x%04x)", pci_get_vendor(self));
 	}
 
-	err = usb2_config_td_setup(&sc->sc_config_td, sc, &(sc->sc_bus.mtx),
+	err = usb2_config_td_setup(&sc->sc_config_td, sc, &sc->sc_bus.mtx,
 	    NULL, 0, 4);
 	if (err) {
 		device_printf(self, "could not setup config thread!\n");

==== //depot/projects/usb/src/sys/dev/usb2/controller/ohci2.c#13 (text+ko) ====

@@ -135,16 +135,16 @@
 	struct ohci_softc *sc = OHCI_BUS2SC(bus);
 	uint32_t i;
 
-	cb(bus, &sc->sc_hw.hcca_pc, &(sc->sc_hw.hcca_pg),
+	cb(bus, &sc->sc_hw.hcca_pc, &sc->sc_hw.hcca_pg,
 	    sizeof(ohci_hcca_t), OHCI_HCCA_ALIGN);
 
-	cb(bus, &sc->sc_hw.ctrl_start_pc, &(sc->sc_hw.ctrl_start_pg),
+	cb(bus, &sc->sc_hw.ctrl_start_pc, &sc->sc_hw.ctrl_start_pg,
 	    sizeof(ohci_ed_t), OHCI_ED_ALIGN);
 
-	cb(bus, &sc->sc_hw.bulk_start_pc, &(sc->sc_hw.bulk_start_pg),
+	cb(bus, &sc->sc_hw.bulk_start_pc, &sc->sc_hw.bulk_start_pg,
 	    sizeof(ohci_ed_t), OHCI_ED_ALIGN);
 
-	cb(bus, &sc->sc_hw.isoc_start_pc, &(sc->sc_hw.isoc_start_pg),
+	cb(bus, &sc->sc_hw.isoc_start_pc, &sc->sc_hw.isoc_start_pg,
 	    sizeof(ohci_ed_t), OHCI_ED_ALIGN);
 
 	for (i = 0; i != OHCI_NO_EDS; i++) {

==== //depot/projects/usb/src/sys/dev/usb2/controller/ohci2_pci.c#9 (text+ko) ====

@@ -280,7 +280,7 @@
 		sprintf(sc->sc_vendor, "(0x%04x)", pci_get_vendor(self));
 	}
 
-	err = usb2_config_td_setup(&sc->sc_config_td, sc, &(sc->sc_bus.mtx),
+	err = usb2_config_td_setup(&sc->sc_config_td, sc, &sc->sc_bus.mtx,
 	    NULL, 0, 4);
 	if (err) {
 		device_printf(self, "could not setup config thread!\n");

==== //depot/projects/usb/src/sys/dev/usb2/controller/uhci2.c#11 (text+ko) ====

@@ -153,22 +153,22 @@
 	struct uhci_softc *sc = UHCI_BUS2SC(bus);
 	uint32_t i;
 
-	cb(bus, &sc->sc_hw.pframes_pc, &(sc->sc_hw.pframes_pg),
+	cb(bus, &sc->sc_hw.pframes_pc, &sc->sc_hw.pframes_pg,
 	    sizeof(uint32_t) * UHCI_FRAMELIST_COUNT, UHCI_FRAMELIST_ALIGN);
 
-	cb(bus, &sc->sc_hw.ls_ctl_start_pc, &(sc->sc_hw.ls_ctl_start_pg),
+	cb(bus, &sc->sc_hw.ls_ctl_start_pc, &sc->sc_hw.ls_ctl_start_pg,
 	    sizeof(uhci_qh_t), UHCI_QH_ALIGN);
 
-	cb(bus, &sc->sc_hw.fs_ctl_start_pc, &(sc->sc_hw.fs_ctl_start_pg),
+	cb(bus, &sc->sc_hw.fs_ctl_start_pc, &sc->sc_hw.fs_ctl_start_pg,
 	    sizeof(uhci_qh_t), UHCI_QH_ALIGN);
 
-	cb(bus, &sc->sc_hw.bulk_start_pc, &(sc->sc_hw.bulk_start_pg),
+	cb(bus, &sc->sc_hw.bulk_start_pc, &sc->sc_hw.bulk_start_pg,
 	    sizeof(uhci_qh_t), UHCI_QH_ALIGN);
 
-	cb(bus, &sc->sc_hw.last_qh_pc, &(sc->sc_hw.last_qh_pg),
+	cb(bus, &sc->sc_hw.last_qh_pc, &sc->sc_hw.last_qh_pg,
 	    sizeof(uhci_qh_t), UHCI_QH_ALIGN);
 
-	cb(bus, &sc->sc_hw.last_td_pc, &(sc->sc_hw.last_td_pg),
+	cb(bus, &sc->sc_hw.last_td_pc, &sc->sc_hw.last_td_pg,
 	    sizeof(uhci_td_t), UHCI_TD_ALIGN);
 
 	for (i = 0; i != UHCI_VFRAMELIST_COUNT; i++) {

==== //depot/projects/usb/src/sys/dev/usb2/controller/uhci2_pci.c#10 (text+ko) ====

@@ -321,7 +321,7 @@
 		break;
 	}
 
-	err = usb2_config_td_setup(&sc->sc_config_td, sc, &(sc->sc_bus.mtx),
+	err = usb2_config_td_setup(&sc->sc_config_td, sc, &sc->sc_bus.mtx,
 	    NULL, 0, 4);
 	if (err) {
 		device_printf(self, "could not setup config thread!\n");

==== //depot/projects/usb/src/sys/dev/usb2/controller/usb2_controller.c#12 (text+ko) ====

@@ -146,7 +146,7 @@
 
 	mtx_lock(&bus->mtx);
 	if (usb2_proc_msignal(&bus->explore_proc,
-	    &bus->detach_msg[0], &(bus->detach_msg[1]))) {
+	    &bus->detach_msg[0], &bus->detach_msg[1])) {
 		/* ignore */
 	}
 	mtx_unlock(&bus->mtx);
@@ -154,7 +154,7 @@
 	/* Wait for detach to complete */
 
 	usb2_proc_mwait(&bus->explore_proc,
-	    &bus->detach_msg[0], &(bus->detach_msg[1]));
+	    &bus->detach_msg[0], &bus->detach_msg[1]);
 
 	/* Get rid of USB explore process */
 

==== //depot/projects/usb/src/sys/dev/usb2/core/usb2_hub.c#17 (text+ko) ====

@@ -1284,7 +1284,7 @@
 		bus->do_probe = 1;
 	}
 	if (usb2_proc_msignal(&bus->explore_proc,
-	    &bus->explore_msg[0], &(bus->explore_msg[1]))) {
+	    &bus->explore_msg[0], &bus->explore_msg[1])) {
 		/* ignore */
 	}
 	mtx_unlock(&bus->mtx);

==== //depot/projects/usb/src/sys/dev/usb2/core/usb2_msctest.c#7 (text+ko) ====

@@ -461,7 +461,7 @@
 	usb2_transfer_start(sc->xfer[sc->state]);
 
 	while (usb2_transfer_pending(sc->xfer[sc->state])) {
-		usb2_cv_wait(&sc->cv, &(sc->mtx));
+		usb2_cv_wait(&sc->cv, &sc->mtx);
 	}
 	return (sc->error);
 }

==== //depot/projects/usb/src/sys/dev/usb2/core/usb2_transfer.c#27 (text+ko) ====

@@ -1751,7 +1751,7 @@
 	         * proceed !
 	         */
 		if (usb2_proc_msignal(&info->done_p,
-		    &info->done_m[0], &(info->done_m[1]))) {
+		    &info->done_m[0], &info->done_m[1])) {
 			/* ignore */
 		}
 	} else {
@@ -1793,7 +1793,7 @@
 	         * proceed !
 	         */
 		if (usb2_proc_msignal(&info->done_p,
-		    &info->done_m[0], &(info->done_m[1]))) {
+		    &info->done_m[0], &info->done_m[1])) {
 			/* ignore */
 		}
 		return;
@@ -2142,7 +2142,7 @@
 			} else if (udev->default_xfer[1]) {
 				info = udev->default_xfer[1]->usb2_root;
 				if (usb2_proc_msignal(&info->done_p,
-				    &udev->cs_msg[0], &(udev->cs_msg[1]))) {
+				    &udev->cs_msg[0], &udev->cs_msg[1])) {
 					/* ignore */
 				}
 			} else {

==== //depot/projects/usb/src/sys/dev/usb2/ethernet/if_aue2.c#9 (text+ko) ====

@@ -780,7 +780,7 @@
 		    "transfers failed!\n");
 		goto detach;
 	}
-	error = usb2_config_td_setup(&sc->sc_config_td, sc, &(sc->sc_mtx),
+	error = usb2_config_td_setup(&sc->sc_config_td, sc, &sc->sc_mtx,
 	    NULL, sizeof(struct usb2_config_td_cc), 16);
 	if (error) {
 		device_printf(dev, "could not setup config "

==== //depot/projects/usb/src/sys/dev/usb2/ethernet/if_axe2.c#9 (text+ko) ====

@@ -620,7 +620,7 @@
 		    "transfers failed!\n");
 		goto detach;
 	}
-	error = usb2_config_td_setup(&sc->sc_config_td, sc, &(sc->sc_mtx),
+	error = usb2_config_td_setup(&sc->sc_config_td, sc, &sc->sc_mtx,
 	    NULL, sizeof(struct usb2_config_td_cc), 16);
 	if (error) {
 		device_printf(dev, "could not setup config "

==== //depot/projects/usb/src/sys/dev/usb2/ethernet/if_cue2.c#9 (text+ko) ====

@@ -424,7 +424,7 @@
 		    "transfers failed!\n");
 		goto detach;
 	}
-	error = usb2_config_td_setup(&sc->sc_config_td, sc, &(sc->sc_mtx),
+	error = usb2_config_td_setup(&sc->sc_config_td, sc, &sc->sc_mtx,
 	    NULL, sizeof(struct usb2_config_td_cc), 16);
 	if (error) {
 		device_printf(dev, "could not setup config "

==== //depot/projects/usb/src/sys/dev/usb2/ethernet/if_kue2.c#9 (text+ko) ====

@@ -488,7 +488,7 @@
 		    "transfers failed!\n");
 		goto detach;
 	}
-	error = usb2_config_td_setup(&sc->sc_config_td, sc, &(sc->sc_mtx),
+	error = usb2_config_td_setup(&sc->sc_config_td, sc, &sc->sc_mtx,
 	    NULL, sizeof(struct usb2_config_td_cc), 16);
 	if (error) {
 		device_printf(dev, "could not setup config "

==== //depot/projects/usb/src/sys/dev/usb2/ethernet/if_rue2.c#9 (text+ko) ====

@@ -673,7 +673,7 @@
 		    "transfers failed!\n");
 		goto detach;
 	}
-	error = usb2_config_td_setup(&sc->sc_config_td, sc, &(sc->sc_mtx),
+	error = usb2_config_td_setup(&sc->sc_config_td, sc, &sc->sc_mtx,
 	    NULL, sizeof(struct usb2_config_td_cc), 16);
 	if (error) {
 		device_printf(dev, "could not setup config "

==== //depot/projects/usb/src/sys/dev/usb2/ethernet/if_udav2.c#9 (text+ko) ====

@@ -289,7 +289,7 @@
 		    "transfers failed!\n");
 		goto detach;
 	}
-	error = usb2_config_td_setup(&sc->sc_config_td, sc, &(sc->sc_mtx),
+	error = usb2_config_td_setup(&sc->sc_config_td, sc, &sc->sc_mtx,
 	    NULL, sizeof(struct usb2_config_td_cc), 16);
 	if (error) {
 		device_printf(dev, "could not setup config "

==== //depot/projects/usb/src/sys/dev/usb2/input/ukbd2.c#8 (text+ko) ====

@@ -666,7 +666,7 @@
 		sc->sc_fkeymap[n] = fkey_tab[n];
 	}
 
-	kbd_set_maps(kbd, &sc->sc_keymap, &(sc->sc_accmap),
+	kbd_set_maps(kbd, &sc->sc_keymap, &sc->sc_accmap,
 	    sc->sc_fkeymap, UKBD_NFKEY);
 
 	KBD_FOUND_DEVICE(kbd);

==== //depot/projects/usb/src/sys/dev/usb2/serial/uark2.c#6 (text+ko) ====

@@ -225,7 +225,7 @@
 	sc->sc_flags |= (UARK_FLAG_BULK_WRITE_STALL |
 	    UARK_FLAG_BULK_READ_STALL);
 
-	error = usb2_com_attach(&sc->sc_super_ucom, &(sc->sc_ucom), 1, sc,
+	error = usb2_com_attach(&sc->sc_super_ucom, &sc->sc_ucom, 1, sc,
 	    &uark_callback, &Giant);
 	if (error) {
 		DPRINTF("usb2_com_attach failed\n");
@@ -243,7 +243,7 @@
 {
 	struct uark_softc *sc = device_get_softc(dev);
 
-	usb2_com_detach(&sc->sc_super_ucom, &(sc->sc_ucom), 1);
+	usb2_com_detach(&sc->sc_super_ucom, &sc->sc_ucom, 1);
 
 	usb2_transfer_unsetup(sc->sc_xfer, UARK_N_TRANSFER);
 

==== //depot/projects/usb/src/sys/dev/usb2/serial/ubsa2.c#8 (text+ko) ====

@@ -362,7 +362,7 @@
 	sc->sc_flag |= (UBSA_FLAG_WRITE_STALL |
 	    UBSA_FLAG_READ_STALL);
 
-	error = usb2_com_attach(&sc->sc_super_ucom, &(sc->sc_ucom), 1, sc,
+	error = usb2_com_attach(&sc->sc_super_ucom, &sc->sc_ucom, 1, sc,
 	    &ubsa_callback, &Giant);
 	if (error) {
 		DPRINTF("usb2_com_attach failed\n");
@@ -382,7 +382,7 @@
 
 	DPRINTF("sc=%p\n", sc);
 
-	usb2_com_detach(&sc->sc_super_ucom, &(sc->sc_ucom), 1);
+	usb2_com_detach(&sc->sc_super_ucom, &sc->sc_ucom, 1);
 
 	usb2_transfer_unsetup(sc->sc_xfer, UBSA_N_TRANSFER);
 

==== //depot/projects/usb/src/sys/dev/usb2/serial/uchcom2.c#7 (text+ko) ====

@@ -378,7 +378,7 @@
 	sc->sc_flag |= (UCHCOM_FLAG_READ_STALL |
 	    UCHCOM_FLAG_WRITE_STALL);
 
-	error = usb2_com_attach(&sc->sc_super_ucom, &(sc->sc_ucom), 1, sc,
+	error = usb2_com_attach(&sc->sc_super_ucom, &sc->sc_ucom, 1, sc,
 	    &uchcom_callback, &Giant);
 	if (error) {
 		goto detach;
@@ -397,7 +397,7 @@
 
 	DPRINTFN(11, "\n");
 
-	usb2_com_detach(&sc->sc_super_ucom, &(sc->sc_ucom), 1);
+	usb2_com_detach(&sc->sc_super_ucom, &sc->sc_ucom, 1);
 
 	usb2_transfer_unsetup(sc->sc_xfer, UCHCOM_N_TRANSFER);
 

==== //depot/projects/usb/src/sys/dev/usb2/serial/ucycom2.c#7 (text+ko) ====

@@ -269,7 +269,7 @@
 		    "transfers failed!\n");
 		goto detach;
 	}
-	error = usb2_com_attach(&sc->sc_super_ucom, &(sc->sc_ucom), 1, sc,
+	error = usb2_com_attach(&sc->sc_super_ucom, &sc->sc_ucom, 1, sc,
 	    &ucycom_callback, &Giant);
 
 	if (error) {
@@ -293,7 +293,7 @@
 {
 	struct ucycom_softc *sc = device_get_softc(dev);
 
-	usb2_com_detach(&sc->sc_super_ucom, &(sc->sc_ucom), 1);
+	usb2_com_detach(&sc->sc_super_ucom, &sc->sc_ucom, 1);
 
 	usb2_transfer_unsetup(sc->sc_xfer, UCYCOM_ENDPT_MAX);
 

==== //depot/projects/usb/src/sys/dev/usb2/serial/ufoma2.c#8 (text+ko) ====

@@ -449,7 +449,7 @@
 	sc->sc_flags |= (UFOMA_FLAG_BULK_WRITE_STALL |
 	    UFOMA_FLAG_BULK_READ_STALL);
 
-	error = usb2_com_attach(&sc->sc_super_ucom, &(sc->sc_ucom), 1, sc,
+	error = usb2_com_attach(&sc->sc_super_ucom, &sc->sc_ucom, 1, sc,
 	    &ufoma_callback, &Giant);
 	if (error) {
 		DPRINTF("usb2_com_attach failed\n");
@@ -467,7 +467,7 @@
 {
 	struct ufoma_softc *sc = device_get_softc(dev);
 
-	usb2_com_detach(&sc->sc_super_ucom, &(sc->sc_ucom), 1);
+	usb2_com_detach(&sc->sc_super_ucom, &sc->sc_ucom, 1);
 
 	usb2_transfer_unsetup(sc->sc_ctrl_xfer, UFOMA_CTRL_ENDPT_MAX);
 

==== //depot/projects/usb/src/sys/dev/usb2/serial/uftdi2.c#7 (text+ko) ====

@@ -326,7 +326,7 @@
 	    FTDI_SIO_SET_DATA_PARITY_NONE |
 	    FTDI_SIO_SET_DATA_BITS(8));
 
-	error = usb2_com_attach(&sc->sc_super_ucom, &(sc->sc_ucom), 1, sc,
+	error = usb2_com_attach(&sc->sc_super_ucom, &sc->sc_ucom, 1, sc,
 	    &uftdi_callback, &Giant);
 	if (error) {
 		goto detach;
@@ -343,7 +343,7 @@
 {
 	struct uftdi_softc *sc = device_get_softc(dev);
 
-	usb2_com_detach(&sc->sc_super_ucom, &(sc->sc_ucom), 1);
+	usb2_com_detach(&sc->sc_super_ucom, &sc->sc_ucom, 1);
 
 	usb2_transfer_unsetup(sc->sc_xfer, UFTDI_ENDPT_MAX);
 

==== //depot/projects/usb/src/sys/dev/usb2/serial/uipaq2.c#8 (text+ko) ====

@@ -1160,7 +1160,7 @@
 	sc->sc_flag |= (UIPAQ_FLAG_READ_STALL |
 	    UIPAQ_FLAG_WRITE_STALL);
 
-	error = usb2_com_attach(&sc->sc_super_ucom, &(sc->sc_ucom), 1, sc,
+	error = usb2_com_attach(&sc->sc_super_ucom, &sc->sc_ucom, 1, sc,
 	    &uipaq_callback, &Giant);
 	if (error) {
 		goto detach;
@@ -1177,7 +1177,7 @@
 {
 	struct uipaq_softc *sc = device_get_softc(dev);
 
-	usb2_com_detach(&sc->sc_super_ucom, &(sc->sc_ucom), 1);
+	usb2_com_detach(&sc->sc_super_ucom, &sc->sc_ucom, 1);
 
 	usb2_transfer_unsetup(sc->sc_xfer_data, UIPAQ_N_DATA_TRANSFER);
 

==== //depot/projects/usb/src/sys/dev/usb2/serial/umct2.c#6 (text+ko) ====

@@ -311,7 +311,7 @@
 			sc->sc_obufsize = 16;
 		}
 	}
-	error = usb2_com_attach(&sc->sc_super_ucom, &(sc->sc_ucom), 1, sc,
+	error = usb2_com_attach(&sc->sc_super_ucom, &sc->sc_ucom, 1, sc,
 	    &umct_callback, &Giant);
 	if (error) {
 		goto detach;
@@ -328,7 +328,7 @@
 {
 	struct umct_softc *sc = device_get_softc(dev);
 
-	usb2_com_detach(&sc->sc_super_ucom, &(sc->sc_ucom), 1);
+	usb2_com_detach(&sc->sc_super_ucom, &sc->sc_ucom, 1);
 
 	usb2_transfer_unsetup(sc->sc_xfer, UMCT_ENDPT_MAX);
 

==== //depot/projects/usb/src/sys/dev/usb2/serial/umodem2.c#8 (text+ko) ====

@@ -396,7 +396,7 @@
 	sc->sc_flag |= (UMODEM_FLAG_READ_STALL |
 	    UMODEM_FLAG_WRITE_STALL);
 
-	error = usb2_com_attach(&sc->sc_super_ucom, &(sc->sc_ucom), 1, sc,
+	error = usb2_com_attach(&sc->sc_super_ucom, &sc->sc_ucom, 1, sc,
 	    &umodem_callback, &Giant);
 	if (error) {
 		goto detach;
@@ -881,7 +881,7 @@
 
 	DPRINTF("sc=%p\n", sc);
 
-	usb2_com_detach(&sc->sc_super_ucom, &(sc->sc_ucom), 1);
+	usb2_com_detach(&sc->sc_super_ucom, &sc->sc_ucom, 1);
 
 	usb2_transfer_unsetup(sc->sc_xfer_intr, UMODEM_N_INTR_TRANSFER);
 

==== //depot/projects/usb/src/sys/dev/usb2/serial/umoscom2.c#7 (text+ko) ====

@@ -348,7 +348,7 @@
 	sc->sc_flags |= (UMOSCOM_FLAG_READ_STALL |
 	    UMOSCOM_FLAG_WRITE_STALL);
 
-	error = usb2_com_attach(&sc->sc_super_ucom, &(sc->sc_ucom), 1, sc,
+	error = usb2_com_attach(&sc->sc_super_ucom, &sc->sc_ucom, 1, sc,
 	    &umoscom_callback, &Giant);
 	if (error) {
 		goto detach;
@@ -370,7 +370,7 @@
 
 	mtx_unlock(&Giant);
 
-	usb2_com_detach(&sc->sc_super_ucom, &(sc->sc_ucom), 1);
+	usb2_com_detach(&sc->sc_super_ucom, &sc->sc_ucom, 1);
 
 	usb2_transfer_unsetup(sc->sc_xfer_data, UMOSCOM_N_DATA_TRANSFER);
 

==== //depot/projects/usb/src/sys/dev/usb2/serial/uplcom2.c#8 (text+ko) ====

@@ -427,7 +427,7 @@
 	sc->sc_flag |= (UPLCOM_FLAG_READ_STALL |
 	    UPLCOM_FLAG_WRITE_STALL);
 
-	error = usb2_com_attach(&sc->sc_super_ucom, &(sc->sc_ucom), 1, sc,
+	error = usb2_com_attach(&sc->sc_super_ucom, &sc->sc_ucom, 1, sc,
 	    &uplcom_callback, &Giant);
 	if (error) {
 		goto detach;
@@ -456,7 +456,7 @@
 
 	DPRINTF("sc=%p\n", sc);
 
-	usb2_com_detach(&sc->sc_super_ucom, &(sc->sc_ucom), 1);
+	usb2_com_detach(&sc->sc_super_ucom, &sc->sc_ucom, 1);
 
 	usb2_transfer_unsetup(sc->sc_xfer, UPLCOM_N_TRANSFER);
 

==== //depot/projects/usb/src/sys/dev/usb2/serial/uvisor2.c#7 (text+ko) ====

@@ -345,7 +345,7 @@
 	sc->sc_flag |= (UVISOR_FLAG_WRITE_STALL |
 	    UVISOR_FLAG_READ_STALL);
 
-	error = usb2_com_attach(&sc->sc_super_ucom, &(sc->sc_ucom), 1, sc,
+	error = usb2_com_attach(&sc->sc_super_ucom, &sc->sc_ucom, 1, sc,
 	    &uvisor_callback, &Giant);
 	if (error) {
 		DPRINTF("usb2_com_attach failed\n");
@@ -365,7 +365,7 @@
 
 	DPRINTF("sc=%p\n", sc);
 
-	usb2_com_detach(&sc->sc_super_ucom, &(sc->sc_ucom), 1);
+	usb2_com_detach(&sc->sc_super_ucom, &sc->sc_ucom, 1);
 
 	usb2_transfer_unsetup(sc->sc_xfer, UVISOR_N_TRANSFER);
 

==== //depot/projects/usb/src/sys/dev/usb2/serial/uvscom2.c#7 (text+ko) ====

@@ -334,7 +334,7 @@
 	sc->sc_flag |= (UVSCOM_FLAG_WRITE_STALL |
 	    UVSCOM_FLAG_READ_STALL);
 
-	error = usb2_com_attach(&sc->sc_super_ucom, &(sc->sc_ucom), 1, sc,
+	error = usb2_com_attach(&sc->sc_super_ucom, &sc->sc_ucom, 1, sc,
 	    &uvscom_callback, &Giant);
 	if (error) {
 		goto detach;
@@ -363,7 +363,7 @@
 	if (sc->sc_xfer[4]) {
 		usb2_transfer_stop(sc->sc_xfer[4]);
 	}
-	usb2_com_detach(&sc->sc_super_ucom, &(sc->sc_ucom), 1);
+	usb2_com_detach(&sc->sc_super_ucom, &sc->sc_ucom, 1);
 
 	usb2_transfer_unsetup(sc->sc_xfer, UVSCOM_N_TRANSFER);
 

==== //depot/projects/usb/src/sys/dev/usb2/sound/uaudio2.c#13 (text+ko) ====

@@ -1316,7 +1316,7 @@
     struct pcm_channel *c, int dir)
 {
 	struct uaudio_chan *ch = ((dir == PCMDIR_PLAY) ?
-	    &sc->sc_play_chan : &(sc->sc_rec_chan));
+	    &sc->sc_play_chan : &sc->sc_rec_chan);
 	uint8_t endpoint;
 	uint8_t iface_index;
 	uint8_t alt_index;

==== //depot/projects/usb/src/sys/dev/usb2/wlan/if_rum2.c#15 (text+ko) ====

@@ -469,7 +469,7 @@
 		    "err=%s\n", usb2_errstr(error));
 		goto detach;
 	}
-	error = usb2_config_td_setup(&sc->sc_config_td, sc, &(sc->sc_mtx),
+	error = usb2_config_td_setup(&sc->sc_config_td, sc, &sc->sc_mtx,
 	    &rum_end_of_commands,
 	    sizeof(struct usb2_config_td_cc), 24);
 	if (error) {

==== //depot/projects/usb/src/sys/dev/usb2/wlan/if_ural2.c#15 (text+ko) ====

@@ -462,7 +462,7 @@
 		    "err=%s\n", usb2_errstr(error));
 		goto detach;
 	}
-	error = usb2_config_td_setup(&sc->sc_config_td, sc, &(sc->sc_mtx),
+	error = usb2_config_td_setup(&sc->sc_config_td, sc, &sc->sc_mtx,
 	    &ural_end_of_commands,
 	    sizeof(struct usb2_config_td_cc), 24);
 	if (error) {

==== //depot/projects/usb/src/sys/dev/usb2/wlan/if_zyd2.c#16 (text+ko) ====

@@ -1097,7 +1097,7 @@
 		    "transfers: %s\n", usb2_errstr(error));
 		goto detach;
 	}
-	error = usb2_config_td_setup(&sc->sc_config_td, sc, &(sc->sc_mtx),
+	error = usb2_config_td_setup(&sc->sc_config_td, sc, &sc->sc_mtx,
 	    &zyd_end_of_commands, sizeof(struct usb2_config_td_cc), 16);
 	if (error) {
 		device_printf(dev, "could not setup config "



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200809210624.m8L6OLBY009942>