Date: Fri, 7 Mar 2008 12:09:07 -0600 From: Brooks Davis <brooks@freebsd.org> To: Maksim Yevmenkin <maksim.yevmenkin@gmail.com> Cc: usselmann.m@icg-online.de, freebsd-bugs@freebsd.org, Brooks Davis <brooks@freebsd.org>, freebsd-rc@freebsd.org Subject: Re: conf/121452: /etc/rc.d/ppp not working as expected Message-ID: <20080307180907.GA45978@lor.one-eyed-alien.net> In-Reply-To: <bb4a86c70803070934r2d736cebp1f3ece888c9ea14a@mail.gmail.com> References: <200803071133.m27BXoXH096841@freefall.freebsd.org> <20080307154951.GB34313@lor.one-eyed-alien.net> <bb4a86c70803070934r2d736cebp1f3ece888c9ea14a@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--LZvS9be/3tNcYl/X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 07, 2008 at 09:34:06AM -0800, Maksim Yevmenkin wrote: > On Fri, Mar 7, 2008 at 7:49 AM, Brooks Davis <brooks@freebsd.org> wrote: > > The following patch should allow profile name to contain ".-/+" charact= ers > > as we do with interfaces. It also documents the previous undocumnted > > per-profile overrides of _mode and _nat which were the cause of the pr= oblem. > > If someone who uses ppp could test this, I'd be happy to commit it. >=20 > i'm not so sure about this one. if i have "t-dsl" as a profile name, i > will not be able to specify any overrides for this profile, because > shell won't let me have "ppp_t-dsl_mode" and/or "ppp_t-dsl_nat" > variable. so, the translation here is not really needed, imo, and, > perhaps, could even be considered harmful. perhaps we should do one of > the following The point of the patch is to change all ".-/+" characters to _ which means the variable will be ppp_t_dsl_(mode|nat) so you can use the profile overrides. It's an exact copy of the code we use for interface variables. > 1) demand that ppp profile names should be "shell clean" and document it >=20 > or >=20 > 2) if a ppp profile name is not "shell clean" simply do not evaluate > profile overrides and use defaults I'm opposed to 2. I'd be OK with 1, but think folding common punctuation into _ may be a better option given that we're already doing it elsewhere. -- Brooks --LZvS9be/3tNcYl/X Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iD8DBQFH0YTCXY6L6fI4GtQRApyRAKDQsykd9iQlm0w2tMdm5GZ/bcFxEgCffJ2d UzuNqSrX7227kKBmTthmqY8= =2EgV -----END PGP SIGNATURE----- --LZvS9be/3tNcYl/X--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080307180907.GA45978>