Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 05 Nov 2000 11:34:05 -0500
From:      "Brian F. Feldman" <green@FreeBSD.org>
To:        Don Lewis <truckman@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/etc MAKEDEV src/release Makefile 
Message-ID:  <200011051634.eA5GY6532929@green.dyndns.org>
In-Reply-To: Message from Don Lewis <truckman@FreeBSD.org>  of "Sun, 05 Nov 2000 07:34:59 PST." <200011051534.HAA97058@freefall.freebsd.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
Don Lewis <truckman@FreeBSD.org> wrote:
> truckman    2000/11/05 07:34:59 PST
> 
>   Modified files:
>     etc                  MAKEDEV 
>     release              Makefile 
>   Log:
>   Change MAKEDEV so that it prepends /sbin:/bin to $PATH instead of totally
>   overwriting $PATH, and find mknod $PATH instead of hardcoding /sbin so
>   that the copy of MAKEDEV on the fixit floppy is usable, since mknod and
>   expr live in /mnt2/stand when the fixit floppy is running.

Ack!  The idea of MAKEDEV having a restricted path is to prevent people from 
repeatedly using stuff from /usr/bin etc. in MAKEDEV, which they love to do. 
This change breaks that.  The right thing to do would be to either one of:
  1) Change the default PATH in MAKEDEV to include the fixit floppy's paths.
  2) Make the fixit floppy set MAKEDEVPATH=/sbin:/bin:/mnt2/stand.

The second is preferred because there's no telling if /mnt2/stand is really 
what you want to be executing stuff from in the non-fixit case.  MAKEDEVPATH 
should be a subset of $PATH consisting only of the bare minimum programs 
that would in a normal system be all in the root partition.

--
 Brian Fundakowski Feldman           \  FreeBSD: The Power to Serve!  /
 green@FreeBSD.org                    `------------------------------'




To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200011051634.eA5GY6532929>