Date: Mon, 18 May 2015 16:11:10 +0200 From: Mathieu Arnold <m@absolight.fr> To: Ian Lepore <ian@freebsd.org> Cc: Adrian Chadd <adrian@freebsd.org>, src-committers@freebsd.org, Eitan Adler <eadler@freebsd.org>, svn-src-all@freebsd.org, phabric-admin@freebsd.org, Zbigniew Bodek <zbb@freebsd.org>, svn-src-head@freebsd.org, Garrett Cooper <yaneurabeya@gmail.com> Subject: Re: svn commit: r282985 - in head/sys: arm/annapurna arm/annapurna/alpine arm/annapurna/alpine/hal arm/conf boot/fdt/dts/arm Message-ID: <64FE26BD563665E5F1B3D0C8@ogg.in.absolight.net> In-Reply-To: <1431957864.91685.57.camel@freebsd.org> References: <201505151825.t4FIPnxJ099637@svn.freebsd.org> <CAJ-Vmomw3QeX4QfwN3ZH%2BcgJGbcJJT0LyjF8d%2B2EX0vExQzYog@mail.gmail.com> <059F2C65-F92D-445C-B603-0FAE0CAF976D@gmail.com> <1431877581.91685.49.camel@freebsd.org> <CAF6rxg=kNFBhDWY0VZKWUb=sVRc-XRtJVGOquEAX=jcdq_CkYA@mail.gmail.com> <7F73A915E7DF0EE8DC6149EC@atuin.in.mat.cc> <1431957864.91685.57.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
+--On 18 mai 2015 08:04:24 -0600 Ian Lepore <ian@freebsd.org> wrote: | On Mon, 2015-05-18 at 10:14 +0200, Mathieu Arnold wrote: |> +--On 18 mai 2015 00:21:43 -0700 Eitan Adler <eadler@freebsd.org> wrote: |> | On 17 May 2015 at 08:46, Ian Lepore <ian@freebsd.org> wrote: |> |> On Sat, 2015-05-16 at 21:04 -0700, Garrett Cooper wrote: |> |>> > On May 16, 2015, at 18:45, Adrian Chadd <adrian@freebsd.org> wrote: |> |>> > |> |>> > Did you commit files with DOS newlines in them? :) |> |>> > |> |>> > tsk tsk tsk tsk tsk. I think should fix that.. |> |>> |> |>> Better yet it should probably be disabled in svn... |> |>> |> |> |> |> Or flagged by some filter as a diff is uploaded to phabricator, since |> |> the web display obscures whitespace. |> | |> | This is possible. Would blocking all diffs that match /\r\n$/ work? |> |> That would crap up all patches that match that, which is a bad idea. |> | | Why would that be a bad idea? Do we have files in the system that | legitimately end with MSDOS line endings that need to be preserved as | such? | | I'm not sure blocking is the right thing anyway, it would be better if | it was like a warning dialog..."The diff you just uploaded contains DOS | line endings, continue?" Mmmm, if this can be done only for base, and not for ports, sure, but ports need to be able to add patches with CRLF endings, because upstream software comes in all flavors, including CRLF files we need to be able to patch. The thing is, in that case, the patch files won't be DOS files, they'll be UNIX files with some lines having \r before the end of line. -- Mathieu Arnold
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?64FE26BD563665E5F1B3D0C8>