From owner-svn-src-all@FreeBSD.ORG Mon May 18 14:11:15 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AE9D9FE0; Mon, 18 May 2015 14:11:15 +0000 (UTC) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 677EE1DFC; Mon, 18 May 2015 14:11:15 +0000 (UTC) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id AD426BDC25; Mon, 18 May 2015 16:11:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=absolight.fr; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=plouf; bh=keWKYU+x/CI eeYCNhR/qUqCvqw0=; b=BmnUwE0evlarmAM+XwvzVLbDbQMfrEgBpvR7AAlgyw+ mnhJpG+M7LcWjomNbtYhCuqW92iHlqsJPsKipDxNSBJ3Fk7cLBNyWKUVm306woH/ Q+/6RAeIL3RdJjwUPxMHg0E5ogT274Nc3fomK6Lz3jBHSbBqH+GXgNTi91E/watk = Received: from gw.in.absolight.net (gw-ecl.in.absolight.net [79.143.241.69]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "gw.in.absolight.net", Issuer "CA Cert Signing Authority" (not verified)) by prod2.absolight.net (Postfix) with ESMTPSA id 91BA6BDC24; Mon, 18 May 2015 16:11:13 +0200 (CEST) Received: from ogg.in.absolight.net (ogg.in.absolight.net [79.143.241.239]) by gw.in.absolight.net (Postfix) with ESMTP id 2BD8C616A; Mon, 18 May 2015 16:11:12 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by ogg.in.absolight.net (Postfix) with ESMTP id 91D9C5E00B4; Mon, 18 May 2015 16:11:10 +0200 (CEST) Date: Mon, 18 May 2015 16:11:10 +0200 From: Mathieu Arnold To: Ian Lepore cc: Adrian Chadd , src-committers@freebsd.org, Eitan Adler , svn-src-all@freebsd.org, phabric-admin@freebsd.org, Zbigniew Bodek , svn-src-head@freebsd.org, Garrett Cooper Subject: Re: svn commit: r282985 - in head/sys: arm/annapurna arm/annapurna/alpine arm/annapurna/alpine/hal arm/conf boot/fdt/dts/arm Message-ID: <64FE26BD563665E5F1B3D0C8@ogg.in.absolight.net> In-Reply-To: <1431957864.91685.57.camel@freebsd.org> References: <201505151825.t4FIPnxJ099637@svn.freebsd.org> <059F2C65-F92D-445C-B603-0FAE0CAF976D@gmail.com> <1431877581.91685.49.camel@freebsd.org> <7F73A915E7DF0EE8DC6149EC@atuin.in.mat.cc> <1431957864.91685.57.camel@freebsd.org> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 May 2015 14:11:15 -0000 +--On 18 mai 2015 08:04:24 -0600 Ian Lepore wrote: | On Mon, 2015-05-18 at 10:14 +0200, Mathieu Arnold wrote: |> +--On 18 mai 2015 00:21:43 -0700 Eitan Adler wrote: |> | On 17 May 2015 at 08:46, Ian Lepore wrote: |> |> On Sat, 2015-05-16 at 21:04 -0700, Garrett Cooper wrote: |> |>> > On May 16, 2015, at 18:45, Adrian Chadd wrote: |> |>> > |> |>> > Did you commit files with DOS newlines in them? :) |> |>> > |> |>> > tsk tsk tsk tsk tsk. I think should fix that.. |> |>> |> |>> Better yet it should probably be disabled in svn... |> |>> |> |> |> |> Or flagged by some filter as a diff is uploaded to phabricator, since |> |> the web display obscures whitespace. |> | |> | This is possible. Would blocking all diffs that match /\r\n$/ work? |> |> That would crap up all patches that match that, which is a bad idea. |> | | Why would that be a bad idea? Do we have files in the system that | legitimately end with MSDOS line endings that need to be preserved as | such? | | I'm not sure blocking is the right thing anyway, it would be better if | it was like a warning dialog..."The diff you just uploaded contains DOS | line endings, continue?" Mmmm, if this can be done only for base, and not for ports, sure, but ports need to be able to add patches with CRLF endings, because upstream software comes in all flavors, including CRLF files we need to be able to patch. The thing is, in that case, the patch files won't be DOS files, they'll be UNIX files with some lines having \r before the end of line. -- Mathieu Arnold