Date: Tue, 25 Jan 2000 01:36:26 +0000 From: Brian Somers <brian@Awfulhak.org> To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu> Cc: Brian Somers <brian@Awfulhak.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@hak.lan.Awfulhak.org Subject: Re: cvs commit: src/sys/conf files src/sys/modules/if_tun Makefile src/sys/net intrq.c intrq.h if_tun.c src/sys/netatalk ddp_input.c src/sys/netatm atm_subr.c src/sys/netinet ip_input.c src/sys/netinet6 ip6_input.c src/sys/netipx ipx_input.c ... Message-ID: <200001250136.BAA36929@hak.lan.Awfulhak.org> In-Reply-To: Message from Garrett Wollman <wollman@khavrinen.lcs.mit.edu> of "Mon, 24 Jan 2000 20:23:24 EST." <200001250123.UAA01185@khavrinen.lcs.mit.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
> <<On Tue, 25 Jan 2000 01:07:14 +0000, Brian Somers <brian@Awfulhak.org> said:
>
> > That's what the *intrq_present variables are for. The file that's
> > #ifdef'd in with (for example) IPX will say
> > ``const int ipxintrq_present = 1;'' whereas intrq.c says
> > ``const int ipxintrq_present;''.
>
> I'd really rather see this implemented as a functional interface (say,
> *_queue_input).
Do you mean to `hide' the *_present variables ? If so, I agree that
something like the following would be better - it's a bit more
protective against rogue modules:
intrq.h:
extern int ipx_enqueue(struct mbuf *);
.....
intrq.c:
int
ipx_enqueue(struct mbuf *m)
{
if (ipxintrq_present) {
IF_ENQUEUE(&ipxintrq, m);
return 0;
}
m_freem(m);
return EAFNOSUPPORT;
}
.....
> -GAWollman
>
> --
> Garrett A. Wollman | O Siem / We are all family / O Siem / We're all the same
> wollman@lcs.mit.edu | O Siem / The fires of freedom
> Opinions not those of| Dance in the burning flame
> MIT, LCS, CRS, or NSA| - Susan Aglukark and Chad Irschick
--
Brian <brian@Awfulhak.org> <brian@FreeBSD.org>
<http://www.Awfulhak.org>; <brian@OpenBSD.org>
Don't _EVER_ lose your sense of humour ! <brian@FreeBSD.org.uk>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200001250136.BAA36929>