Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 6 Aug 2019 16:12:43 +0000 (UTC)
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r350638 - stable/11/contrib/bsnmp/lib
Message-ID:  <201908061612.x76GChOd007362@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: emaste
Date: Tue Aug  6 16:12:43 2019
New Revision: 350638
URL: https://svnweb.freebsd.org/changeset/base/350638

Log:
  MFC r350635: bsnmp: add asn1 message length validation
  
  admbugs:	780
  Submitted by:	Guido Vranken, bz
  Reported by:	Guido Vranken
  Approved by:	so
  Security:	CVE-2019-5610

Modified:
  stable/11/contrib/bsnmp/lib/asn1.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/contrib/bsnmp/lib/asn1.c
==============================================================================
--- stable/11/contrib/bsnmp/lib/asn1.c	Tue Aug  6 16:11:16 2019	(r350637)
+++ stable/11/contrib/bsnmp/lib/asn1.c	Tue Aug  6 16:12:43 2019	(r350638)
@@ -100,6 +100,11 @@ asn_get_header(struct asn_buf *b, u_char *type, asn_le
 		*len = *b->asn_cptr++;
 		b->asn_len--;
 	}
+	if (*len > b->asn_len) {
+		asn_error(b, "len %u exceeding asn_len %u", *len, b->asn_len);
+		return (ASN_ERR_EOBUF);
+	}
+	
 	return (ASN_ERR_OK);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201908061612.x76GChOd007362>