Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 31 Dec 2017 17:57:27 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Yuri <yuri@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r457707 - in head/devel/rapidjson: . files
Message-ID:  <20171231175727.GB40708@FreeBSD.org>
In-Reply-To: <b8012219-8972-175b-bfc9-c535b93d33c0@freebsd.org>
References:  <201712311714.vBVHEEWC044612@repo.freebsd.org> <20171231173805.GA40708@FreeBSD.org> <b8012219-8972-175b-bfc9-c535b93d33c0@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Dec 31, 2017 at 09:44:28AM -0800, Yuri wrote:
> On 12/31/17 09:38, Alexey Dokuchaev wrote:
> > OK, so it's all about fixing clang warnings...
> 
> This patch was submitted as fixing warnings.

It does not matter how/what/why the patch was submitted.  You're the one
committing it, and you are expected to provide appropriate commit log.

> There are some other minor, cosmetic changes too, that make practically

The fact that development was handed over to Tencent does not seem minor.

> no difference.

*sigh*

Please summarize committed changes completely and thoroughly.  I don't
even understand why we need to talk about it again, again, and again.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171231175727.GB40708>