From owner-cvs-all Tue Sep 28 7:44:29 1999 Delivered-To: cvs-all@freebsd.org Received: from overcee.netplex.com.au (overcee.netplex.com.au [202.12.86.7]) by hub.freebsd.org (Postfix) with ESMTP id E4A5214FA1; Tue, 28 Sep 1999 07:44:04 -0700 (PDT) (envelope-from peter@netplex.com.au) Received: from netplex.com.au (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id 3155A1CC1; Tue, 28 Sep 1999 22:44:03 +0800 (WST) (envelope-from peter@netplex.com.au) X-Mailer: exmh version 2.0.2 2/24/98 To: Marcel Moolenaar Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/gen getcwd.c In-reply-to: Your message of "Tue, 28 Sep 1999 06:24:14 MST." <199909281324.GAA08484@freefall.freebsd.org> Date: Tue, 28 Sep 1999 22:44:03 +0800 From: Peter Wemm Message-Id: <19990928144403.3155A1CC1@overcee.netplex.com.au> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Marcel Moolenaar wrote: > marcel 1999/09/28 06:24:14 PDT > > Modified files: > lib/libc/gen getcwd.c > Log: > Explicitly use sigemptyset to clear a sigset_t. Explicit > initialization of sa_flags allows us to lose the bzero. Hmm.. my experience on other systems suggests sigactions should be pre-bzeroed (or memset) for portability reasons. This is required on some OS's as there are hidden fields in there, and doesn't require modifying the whole tree when a new field is added or changed to struct sigaction. eg, on another system: struct sigaction { int sa_flags; void (*sa_handler)(); sigset_t sa_mask; int sa_resv[2]; }; The programmer can't be expected to know what local additions to sigaction an OS may have. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message