From owner-freebsd-stable@FreeBSD.ORG Tue Jan 29 19:17:05 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 1D8093B9; Tue, 29 Jan 2013 19:17:05 +0000 (UTC) (envelope-from kpaasial@gmail.com) Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by mx1.freebsd.org (Postfix) with ESMTP id 5C48F128; Tue, 29 Jan 2013 19:17:04 +0000 (UTC) Received: by mail-wi0-f177.google.com with SMTP id hm14so800333wib.16 for ; Tue, 29 Jan 2013 11:17:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=4zA0fvUFxunUL8rn+3LseTdDgc2OAfOAITnzUNjeLxg=; b=Lo0gJY/3l/zJZq8xaDr3v9bdLZ//iVmlOJ1cCOkGkvmXR8Weolq7sAtjgCo20a1/8k fD1Ci63pVDdOfLBBmcsZaLnSpWs+9EEbCOZRBnOL85U0mlv2K3JtfR7o+TrlXGYcDvNj 1w7srK52ALRzxTHX0aBqEgktDXgm4wjQuUqrhuauHiRYCGhYw01kq/ogzMZy8JyPPLcL Q2wLVuvWQIAQ45pK1nBbMML0JyGTRurhF53QAfE2HJsoNX6TaA8VMmFW3QCJ557k0b+1 wvvsMFmGapHrA5vvNH1t4BCuAuVdO3ZHVnt7k+DLPvyVrmKPynsD39GcAjSs+ajRKMIk 0vdg== MIME-Version: 1.0 X-Received: by 10.180.100.163 with SMTP id ez3mr4283110wib.32.1359487023290; Tue, 29 Jan 2013 11:17:03 -0800 (PST) Received: by 10.216.172.197 with HTTP; Tue, 29 Jan 2013 11:17:03 -0800 (PST) In-Reply-To: <51081E18.60303@sentex.net> References: <50F6D20A.6070306@FreeBSD.org> <20130117001116.GD29437@lor.one-eyed-alien.net> <50F81588.5020106@FreeBSD.org> <51081E18.60303@sentex.net> Date: Tue, 29 Jan 2013 21:17:03 +0200 Message-ID: Subject: Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9 From: Kimmo Paasiala To: Mike Tancsa Content-Type: text/plain; charset=UTF-8 Cc: freebsd-stable@freebsd.org, Brooks Davis , Dimitry Andric X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jan 2013 19:17:05 -0000 On Tue, Jan 29, 2013 at 9:08 PM, Mike Tancsa wrote: > On 1/17/2013 4:35 PM, Kimmo Paasiala wrote: >> On Thu, Jan 17, 2013 at 5:15 PM, Dimitry Andric wrote: >>> On 2013-01-17 14:07, Kimmo Paasiala wrote: >>>> >>>> On Thu, Jan 17, 2013 at 2:11 AM, Brooks Davis wrote: >>> >>> ... >>> >>> Please try the following patch, which tells configure that HAVE_STRNVIS >>> is always false. I think this is the easiest way, unless we really want >>> the port to use our own strnvis. >> >> This will still leave the exported symbol in the plugin binary with >> the name strnvis. What would be needed is renaming of the function to >> something else, like pam_ssh_agent_auth_strnvis(), maybe using a macro >> >> #define strnvis pam_ssh_agent_auth_strnvis >> >> somewhere. >> >> I can try my hand on coming up with a fix but its going to take some >> time, the source code of the plugin and not to mention the configure >> script look quite hairy. > > Hi, > Just wondering if anyone ever came up with a patch / work around to this ? > > ---Mike > > > -- Hi, Yes I did in fact but it's a really quick and dirty hack. I renamed the openbsd strnvis to strnvis_local so the symbol in plugin binary won't conflict with strnvis from libc. I'll have to see if I can clean it up and submit a PR with a diff. -Kimmo