Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 Oct 2008 16:05:41 -0400
From:      Jung-uk Kim <jkim@FreeBSD.org>
To:        "Attilio Rao" <attilio@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r184108 - head/sys/i386/i386
Message-ID:  <200810211605.46927.jkim@FreeBSD.org>
In-Reply-To: <3bbf2fe10810210307t664cc8a2s62606f03427286f3@mail.gmail.com>
References:  <200810210431.m9L4V7Pb088978@svn.freebsd.org> <3bbf2fe10810210307t664cc8a2s62606f03427286f3@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 21 October 2008 06:07 am, Attilio Rao wrote:
> Something we could do with this is adding a "quirk" table of TSC
> arch dependant known to be working (based on cpu_model and such)
> and use that table in order to replace tsc_smp.

Please note the invariant_tsc and smp_tsc are different.  If we go 
with the route, we need two quirk tables. :-(

BTW, Linux is using TSC now when the P-state invariant TSC bit is set 
by BIOS for AMD CPUs:

http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg246251.html
http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg246769.html

"After a lot of discussions with AMD it turns out that TSC on Fam10h 
CPUs is synchronized when the CONSTANT_TSC cpuid bit is set. Or 
rather that if there are ever systems where that is not true it would 
be their BIOS' task to disable the bit."

If this is statement is true, then we should do:

	if (amd_pminfo & AMDPM_TSC_INVARIANT)
		smp_tsc = 1;

Also, I think we can safely assume:

	if (AMD64_FAMILY(cpu_id) >= 0x10)
		tsc_is_invariant = 1;

Does anyone know whether these are correct assumptions?

Jung-uk Kim



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200810211605.46927.jkim>