From owner-cvs-all Tue May 8 10:50:32 2001 Delivered-To: cvs-all@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id C8E2437B422; Tue, 8 May 2001 10:50:26 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by meow.osd.bsdi.com (8.11.2/8.11.2) with ESMTP id f48HoHG19416; Tue, 8 May 2001 10:50:17 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200105081215.f48CFRK29756@freefall.freebsd.org> Date: Tue, 08 May 2001 10:49:23 -0700 (PDT) From: John Baldwin To: Seigo Tanimura Subject: RE: cvs commit: src/sys/dev/sound/isa mpu.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 08-May-01 Seigo Tanimura wrote: > tanimura 2001/05/08 05:15:27 PDT > > Modified files: > sys/dev/sound/isa mpu.c > Log: > - Eliminate locks in functions called only during probe and attach. > - Finish transmitting data to mpu when a buffer gets empty. > > Submitted by: KUROSAWA Takahiro If a function is required to be called with locks held, then use a mtx_assert() to require it. For example: mtx_assert(&scp->mtx, MA_OWNED) will panic if the mutex scp->mtx is not held. Note that like KASSERT(), mtx_assert()'s are only triggered in the INVARIANTS case. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message