From owner-cvs-all@FreeBSD.ORG Sat Mar 20 13:33:49 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 917FD16A520; Sat, 20 Mar 2004 13:33:47 -0800 (PST) Received: from sasami.jurai.net (sasami.jurai.net [66.92.160.223]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D84544039; Sat, 20 Mar 2004 13:05:50 -0800 (PST) (envelope-from mdodd@FreeBSD.ORG) Received: from sasami.jurai.net (winter@sasami.jurai.net [66.92.160.223]) by sasami.jurai.net (8.12.9/8.12.9) with ESMTP id i2KL5n7t037932; Sat, 20 Mar 2004 16:05:49 -0500 (EST) (envelope-from mdodd@FreeBSD.ORG) Date: Sat, 20 Mar 2004 16:05:48 -0500 (EST) From: "Matthew N. Dodd" X-X-Sender: winter@sasami.jurai.net To: Ruslan Ermilov In-Reply-To: <20040314083743.GC62719@ip.net.ua> Message-ID: <20040320160450.T32310@sasami.jurai.net> References: <200403140524.i2E5OsgV073250@repoman.freebsd.org> <20040314083743.GC62719@ip.net.ua> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/net if_ethersubr.c if_fddisubr.c if_iso88025subr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Mar 2004 21:33:50 -0000 On Sun, 14 Mar 2004, Ruslan Ermilov wrote: > : + case AF_ARP: > : + { > : + struct arphdr *ah; > : + ah = mtod(m, struct arphdr *); > : + ah->ar_hrd = htons(ARPHRD_ETHER); > > Is it safe to not do m_pullup() here and there? Yes. The only codepath that results in the AF_ARP case performs the mbuf alloction with sufficient size. I'll be committing this later today. -- 10 40 80 C0 00 FF FF FF FF C0 00 00 00 00 10 AA AA 03 00 00 00 08 00