Date: Sat, 13 May 2006 16:53:44 GMT From: Sam Lawrance <lawrance@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/97207: [update] devel/portlint - check for quoted COMMENT does not work Message-ID: <200605131653.k4DGri0s097784@freefall.freebsd.org> Resent-Message-ID: <200605131700.k4DH0cWG097977@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 97207
>Category: ports
>Synopsis: [update] devel/portlint - check for quoted COMMENT does not work
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Sat May 13 17:00:37 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: Sam Lawrance
>Release: FreeBSD 6.0-STABLE i386
>Organization:
>Environment:
>Description:
Portlint's check for quoted a COMMENT, eg
COMMENT= "Apple's mDNSResponder"
does not flag any errors.
>How-To-Repeat:
Try it out on mDNSResponder. Unless I update it first :-)
>Fix:
Patch attached. The section that specifically checks COMMENT is
removed, and COMMENT is added below to the list of variables to check
for quoted-ness.
--- patch-portlint begins here ---
Index: src/portlint.pl
===================================================================
RCS file: /home/pcvs/ports/devel/portlint/src/portlint.pl,v
retrieving revision 1.88
diff -u -r1.88 portlint.pl
--- src/portlint.pl 12 Mar 2006 19:19:43 -0000 1.88
+++ src/portlint.pl 13 May 2006 16:48:05 -0000
@@ -1202,20 +1202,10 @@
}
#
- # whole file: COMMENT
- #
- print "OK: checking COMMENT.\n" if ($verbose);
- if ($whole =~ /^COMMENT[+?]?=[ \t]+"[^"+]"$/m) {
- my $lineno = &linenumber($`);
- &perror("WARN: $file [$lineno]: COMMENT messages should not ".
- "be quoted.");
- }
-
- #
# whole file: BROKEN et al.
#
my ($var);
- foreach $var (qw(IGNORE BROKEN FORBIDDEN MANUAL_PACKAGE_BUILD NO_CDROM NO_PACKAGE RESTRICTED)) {
+ foreach $var (qw(IGNORE BROKEN COMMENT FORBIDDEN MANUAL_PACKAGE_BUILD NO_CDROM NO_PACKAGE RESTRICTED)) {
print "OK: checking ${var}.\n" if ($verbose);
if ($whole =~ /\n${var}[+?]?=[ \t]+"/) {
my $lineno = &linenumber($`);
--- patch-portlint ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200605131653.k4DGri0s097784>