From owner-freebsd-arm@FreeBSD.ORG Sat Feb 2 18:52:50 2008 Return-Path: Delivered-To: arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1B5CD16A41A for ; Sat, 2 Feb 2008 18:52:50 +0000 (UTC) (envelope-from xride@x12.dk) Received: from mx01.stofanet.dk (mx01.stofanet.dk [212.10.10.11]) by mx1.freebsd.org (Postfix) with ESMTP id A2A7F13C457 for ; Sat, 2 Feb 2008 18:52:49 +0000 (UTC) (envelope-from xride@x12.dk) Received: from 5634d033.rev.stofanet.dk ([86.52.208.51] helo=beacon.x12.dk) by mx01.stofanet.dk (envelope-from ) with esmtp id 1JLNTb-000123-0f; Sat, 02 Feb 2008 19:52:32 +0100 Received: from localhost (localhost [127.0.0.1]) by beacon.x12.dk (Postfix) with ESMTP id F400B28417; Sat, 2 Feb 2008 19:52:30 +0100 (CET) Date: Sat, 2 Feb 2008 19:52:11 +0100 From: Soeren Straarup To: Olivier Houchard Message-ID: <20080202195211.10ca3182@x12.dk> In-Reply-To: <20080202190933.GA18088@ci0.org> References: <20080202090238.289eeb66@x12.dk> <20080202183138.GA17602@ci0.org> <20080202185449.6b9068a2@x12.dk> <20080202190933.GA18088@ci0.org> X-Mailer: Claws Mail 3.0.2 (GTK+ 2.12.5; i386-portbld-freebsd8.0) Telephone: +4575581244 +13612371008 Mobil: +4520276244 X-Face: 7Y!o?/XT:H%BE>uVwW9m14t\pR.ZF]T!3s$d_`Gv6TVIknyh$"aMW=:t(r}QL:3W, Ico:Gec Ksmq@nVq-$Ks_33F0L>R[^qp'3-g4eV#nKv/8rl",TY4NTKO&DRL)e(x^6Tn^9".i; oJf-l69YL+>hY- }/$J[OE(pIER<2n`8E_}HLv`tXVvUr^O%#4 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: arm@freebsd.org Subject: Re: about src/lib/libkse/arch/arm/include/pthread_md.h X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Feb 2008 18:52:50 -0000 On Sat, 2 Feb 2008 20:09:33 +0100 Olivier Houchard wrote: > On Sat, Feb 02, 2008 at 06:54:49PM +0100, Soeren Straarup wrote: > > On Sat, 2 Feb 2008 19:31:38 +0100 > > Olivier Houchard wrote: > > > > > Hi Soeren, > > > > > > On Sat, Feb 02, 2008 at 09:02:38AM +0100, Soeren Straarup wrote: > > > > Hi, > > > > > > > > Index: pthread_md.h > > > > =================================================================== > > > > RCS > > > > file: /home/ncvs/src/lib/libkse/arch/arm/include/pthread_md.h,v > > > > retrieving revision 1.9 diff -u -r1.9 pthread_md.h > > > > --- pthread_md.h 9 Oct 2007 13:42:23 -0000 1.9 > > > > +++ pthread_md.h 1 Feb 2008 22:48:50 -0000 > > > > @@ -240,7 +240,7 @@ > > > > tcb->tcb_tmbx.tm_lwp = kcb->kcb_kmbx.km_lwp; > > > > if (setmbox) > > > > _thr_setcontext(mc, > > > > (intptr_t)&tcb->tcb_tmbx, > > > > - (intptr_t > > > > *)&kcb->kcb_kmbx.km_curthread); > > > > + (intptr_t > > > > *)kcb->kcb_kmbx.km_curthread); else > > > > _thr_setcontext(mc, 0, NULL); > > > > } else { > > > > > > > > > > > > Is that change correct? > > > > > > > > > > If I'm nor wrong, the original code is right, and that's what the > > > other platforms seem to do so. Why do you think it should be > > > changed ? > > > > > > > Due to that if gcc is run with warnings set as errors it breaks. > > > > We probably should do what other platforms do, and cast it to (void *) > before (intptr_t *). > Wanna commit it, or shall I ? If you would then it would be in the right way (8 Hint i'm a ports committer /Soeren -- Soeren Straarup | aka OZ2DAK aka Xride FreeBSD committer | FreeBSD since 2.2.6-R If a program is not working right, then send a patch