Date: Fri, 19 Jan 2007 17:41:08 -0500 From: John Baldwin <jhb@freebsd.org> To: src-committers@freebsd.org Cc: cvs-src@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/aic7xxx aic79xx.h aic79xx_pci.c src/sys/dev/pci pcireg.h Message-ID: <200701191741.08659.jhb@freebsd.org> In-Reply-To: <200701192237.l0JMbqNI009192@repoman.freebsd.org> References: <200701192237.l0JMbqNI009192@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 19 January 2007 17:37, John Baldwin wrote: > jhb 2007-01-19 22:37:52 UTC > > FreeBSD src repository > > Modified files: > sys/dev/aic7xxx aic79xx.h aic79xx_pci.c > sys/dev/pci pcireg.h > Log: > - Change the PCI-X registers constants to be relative to the PCI-X PCI > capability rather than hardcoded offsets for a particular card. While > I'm here, expand the constants some. > - Change the ahd(4) driver to use pci_find_extcap() to locate the PCI-X > capability to keep up with the first change. > > Reviewed by: scottl, gibbs (earlier version) Note that in Justin's defense, we didn't have a pci_find_extcap() function back when he added these constants, so he didn't have much of a choice other than hardcoding them. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200701191741.08659.jhb>