Date: Sun, 16 Apr 2017 16:51:29 -0400 From: Diane Bruce <db@db.net> To: Diane Bruce <db@db.net> Cc: Kyle Evans <bsdports@kyle-evans.net>, Alexey Dokuchaev <danfe@freebsd.org>, Diane Bruce <db@freebsd.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r436814 - in head/comms: . direwolf direwolf/files Message-ID: <20170416205129.GA793@night.db.net> In-Reply-To: <20170325032842.GA90279@night.db.net> References: <201703241401.v2OE1nwY023666@repo.freebsd.org> <20170325014740.GC54562@FreeBSD.org> <CACNAnaFhG=WufG3VP3TG6CZWf507X=OFWzif2YUm8==JDKEuGg@mail.gmail.com> <20170325032842.GA90279@night.db.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Looks like this was my mistake. Kyle I thought you were going to
do a new PR with an updated upstream with the universal Makefile.
Was your fix approved upstream? They have at least one update after
this commit.
- Diane
On Fri, Mar 24, 2017 at 11:28:42PM -0400, Diane Bruce wrote:
> On Fri, Mar 24, 2017 at 09:28:26PM -0500, Kyle Evans wrote:
> > On Fri, Mar 24, 2017 at 8:47 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> > > It was not explained why the FreeBSD version of Makefile is needed at all.
> > > What's wrong with original version? Most of its contents are not related
> > > to FreeBSD in any way.
> >
> > The project Makefile does a basic OS check then includes
> > Makefile.{linux,macosx,win}. The linux/macosx makefiles contain enough
> > platform specific things that we saw fit to write a FreeBSD version.
> > We're doing some work with upstream to get this integrated into
> > Direwolf in a manner that's more maintainable by all.
>
> It looked as if upstream simply preferred a separate platform
> specific Makefile much as other projects have done in the past;
> But after requesting a pull request upstream expressed a preference
> for a single Makefile and work was started on this.
>
> >
> > I'm attaching a patch that should address your concerns, with
> > PORTREVISION bumped due to the dw-start.sh change -- /usr/local was
>
> I note that upstream already have a change we can pull in with
> next iteration hence a PORTREVISION will not be necessary.
>
> >
> > Thanks,
> >
> > Kyle Evans
>
> --
> - db@FreeBSD.org db@db.net http://www.db.net/~db
>
--
- db@FreeBSD.org db@db.net http://www.db.net/~db
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170416205129.GA793>