From owner-freebsd-current@FreeBSD.ORG Tue Jul 9 20:34:13 2013 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 035DA83C for ; Tue, 9 Jul 2013 20:34:13 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id B5D7C1AC6 for ; Tue, 9 Jul 2013 20:34:12 +0000 (UTC) Received: from outgoing.leidinger.net (pD9FBBBE3.dip0.t-ipconnect.de [217.251.187.227]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 9D63484408D; Tue, 9 Jul 2013 22:33:59 +0200 (CEST) Received: from unknown (Titan.Leidinger.net [192.168.1.17]) by outgoing.leidinger.net (Postfix) with ESMTP id 37A9BD64; Tue, 9 Jul 2013 22:33:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=leidinger.net; s=outgoing-alex; t=1373402037; bh=2V9mmk/+IDqkcNm3cAsXVm4f8EBsWQo53+3SqKsM4ss=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=rFXAS5757t1ninvGNzLo5O4V1vBk6qah1YeMhNgWoctOxpS5L1nD5C6dg9GcIFbeq ith5PWln/CVz9FvWr3PhhBQkMVnlz4JMOfA0ycQlyxsbBEvtktWlKmFxTmrZzE7yxx Ngm2gaOqkV7fUzYymA7/BV0xZEolLPGtcBGNdH8HkUVChg76Sm3rru3XfOf2OlMs4+ SzJVIBp3wn/iUAri2b5IDqpt4y9nE/A0IJ3rR/618hkGgQkFOjuDYQg8rWUiuSgQ5P er0uBuW4p+B98rpV2BeKEKsSyMgEsFxyXAFOm51j8Y0ESGzB+9yjfd+81OP9HHqsbA jAbDOchHil9Ng== Date: Tue, 9 Jul 2013 22:33:56 +0200 From: Alexander Leidinger To: gljennjohn@googlemail.com Subject: Re: kernel compile broken in latest HEAD Message-ID: <20130709223356.000005ad@unknown> In-Reply-To: <20130709173233.275469b4@ernst.home> References: <20130709173233.275469b4@ernst.home> X-Mailer: Claws Mail 3.9.1-2-g66aa06 (GTK+ 2.16.6; i586-pc-mingw32msvc) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 9D63484408D.AF0B8 X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-0.979, required 6, autolearn=disabled, ALL_TRUSTED -1.00, AWL 0.13, DKIM_SIGNED 0.10, DKIM_VALID -0.10, DKIM_VALID_AU -0.10, T_RP_MATCHES_RCVD -0.01, URIBL_BLOCKED 0.00) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1374006839.82287@s7l9jtCZLHJ1r/we7fKXSw X-EBL-Spam-Status: No Cc: FreeBSD Current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jul 2013 20:34:13 -0000 On Tue, 9 Jul 2013 17:32:33 +0200 Gary Jennejohn wrote: > I just saw this breakage while compiling a kernel on HEAD updated > minutes ago: Is your cc a gcc or clang? My one is clang and I didn't get build errors when I tested the commit. I was told there are those errors with gcc. My question in the corresponding thread is so far unanswered. Here's what I wrote as a reference: ---snip--- Does someone know what this is supposed to result in? I would assume as the unions are unnamed and no variable is declared inside the struct with it, that the size of the struct is the same as not having those unions inside the structs. If this is correct I would assume the correct fix would be to #if-0 them out. ---snip--- > These line numbers all point at nameless unions. > > Seems to me that a union needs a name, otherwise one cannot > access its contents. > > I simply named them all x to get the kernel to compile, which > succeeded. Did you name it x ("union x {...};"), or did you declare a variable x with it ("union {...} x;")? Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137