Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 9 Jun 2018 18:04:19 -0400
From:      Steve Wills <steve@mouf.net>
To:        Eugene Grosbein <eugen@grosbein.net>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, dev@dudu.ro
Subject:   Re: svn commit: r472097 - in head/databases/mongodb36: . files
Message-ID:  <75fe1030-630c-9ce5-7f9e-a07123db6902@mouf.net>
In-Reply-To: <5B1C4B96.9060907@grosbein.net>
References:  <201806092133.w59LXtVZ035695@repo.freebsd.org> <5B1C4B96.9060907@grosbein.net>

next in thread | previous in thread | raw e-mail | index | archive | help
Fair enough, perhaps even a patch to add a comment in the file would be
useful. Note too that it can be overridden.

Steve

On 06/09/18 17:50, Eugene Grosbein wrote:
> 10.06.2018 4:33, Steve Wills wrote:
> 
>> Author: swills
>> Date: Sat Jun  9 21:33:55 2018
>> New Revision: 472097
>> URL: https://svnweb.freebsd.org/changeset/ports/472097
>>
>> Log:
>>   databases/mongodb36: upgrade to 3.6.5
>>   
>>   PR:		228806
>>   Submitted by:	dev@dudu.ro (maintainer)
> 
> [skip[
> 
>> Modified: head/databases/mongodb36/files/mongod.in
>> ==============================================================================
>> --- head/databases/mongodb36/files/mongod.in	Sat Jun  9 21:30:38 2018	(r472096)
>> +++ head/databases/mongodb36/files/mongod.in	Sat Jun  9 21:33:55 2018	(r472097)
>> @@ -30,7 +30,7 @@ load_rc_config $name
>>  : ${mongod_enable="NO"}
>>  %%LEGACY_LIMITS%%: ${mongod_limits="NO"}
>>  : ${mongod_dbpath="/var/db/mongodb"}
>> -: ${mongod_flags="--logpath ${mongod_dbpath}/mongod.log --logappend"}
>> +: ${mongod_flags="--logpath ${mongod_dbpath}/mongod.log --logappend --setParameter=disabledSecureAllocatorDomains=\*"}
>>  : ${mongod_user="mongodb"}
>>  : ${mongod_group="mongodb"}
>>  : ${mongod_config="%%PREFIX%%/etc/mongodb.conf"}
> 
> The change seems suspictious to uneducated eye. Perhaps, some commentary in the commit log
> would be useful, like: mongodb36 now requires disabling "SecureAllocator" that uses mlock()
> to be useful for restricted users, or else it crashes with SIGABRT in fassert()
> complaining "Failed to mlock: Operation not permitted".
> 
>  
> 
> 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?75fe1030-630c-9ce5-7f9e-a07123db6902>