From owner-freebsd-ports@FreeBSD.ORG Wed Jul 23 15:06:25 2008 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D76171065684 for ; Wed, 23 Jul 2008 15:06:25 +0000 (UTC) (envelope-from florent.thoumie@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.178]) by mx1.freebsd.org (Postfix) with ESMTP id B40A88FC13 for ; Wed, 23 Jul 2008 15:06:25 +0000 (UTC) (envelope-from florent.thoumie@gmail.com) Received: by wa-out-1112.google.com with SMTP id j4so1302493wah.3 for ; Wed, 23 Jul 2008 08:06:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=VB/CbedhXyBOzUvtwvMX2YT76PjMDJBjIILkKG4+N9Y=; b=oiThKeQPbXrKYmhe7Pucblb1sxScrVx0kpgZg840wJlNncXeB2pd1HhGhk4MYXq3Zk V79lezRY2/S4UXKz3+WSc09G32Z5vnH5oqN92Mpgej8QTDFcR/TbKGY8UC7MCaDy0hnC Ksg8NJKOyli6smmkrWkNioAZ5nmdtlPIsRGrs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=E9dVScADVpzFa8yMLEoGOoCMPx5vg69FiB3H11KwqynDMv32Nml5FXrg2VG4fn+GB2 +p+WhWOKcdUd0CeZGjnqLwvpB2E7NtTfKfUukyK0qA7JZZUVLCuJdGB7O4xnC/DUSCRf ac85oN+MYjvM92qBUrPdxwETQMbFT4l+/9EjE= Received: by 10.115.58.1 with SMTP id l1mr146257wak.27.1216825584918; Wed, 23 Jul 2008 08:06:24 -0700 (PDT) Received: by 10.114.60.15 with HTTP; Wed, 23 Jul 2008 08:06:24 -0700 (PDT) Message-ID: Date: Wed, 23 Jul 2008 16:06:24 +0100 From: "Florent Thoumie" Sender: florent.thoumie@gmail.com To: "Ion-Mihai Tetcu" In-Reply-To: <20080723151212.18dfb88d@it.buh.tecnik93.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1592773212-1216766394-cardhu_decombobulator_blackberry.rim.net-2001801074-@bxe056.bisx.produk.on.blackberry> <20080723151212.18dfb88d@it.buh.tecnik93.com> X-Google-Sender-Auth: b7fcb015de4af660 Cc: ports@freebsd.org, Olafur Osvaldsson , pgollucci@freebsd.org, araujo@freebsd.org Subject: Re: ports/125625: [PATCH] dns/nsd: USE_RC_SUBR != yes X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2008 15:06:25 -0000 On Wed, Jul 23, 2008 at 1:12 PM, Ion-Mihai Tetcu wrote: > On Wed, 23 Jul 2008 13:08:03 +0100 > "Florent Thoumie" wrote: > >> On Wed, Jul 23, 2008 at 12:30 PM, Olafur Osvaldsson >> wrote: >> > This is something the PR responsible introduced in his original >> > patch... >> >> It's still present in your version. Anyway, I'm not blaming anyone, >> just pointing out what I think is a mistake. > > So this is not for the user but for the port? > > I'll do a swap on the tree for it, because I'm sure there are more > ports doing something like: > .ifndef(NO_INSTALL_MANPAGES) > ...... > .endif The general rule of thumb is: if it doesn't begin with WITH_ or WITHOUT_, it's not user-settable. NO_INSTALL_MANPAGES is used for ports using imake that don't understand the install.man target. Now of course there are exceptions (usually for no good reason IMHO). The likes of NOPORTDOCS/NOPORTEXAMPLES/... could be changed to WITHOUT_DOCS/WITHOUT_EXAMPLES, it's just waiting for somebody to do the work. -- Florent Thoumie flz@FreeBSD.org FreeBSD Committer