Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 9 Dec 2003 05:20:03 -0800 (PST)
From:      Yar Tikhiy <yar@FreeBSD.ORG>
To:        freebsd-bugs@FreeBSD.org
Subject:   Re: kern/47920: if ng_pppoe switches to nonstandard mode it stays in it forever
Message-ID:  <200312091320.hB9DK3YG093452@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/47920; it has been noted by GNATS.

From: Yar Tikhiy <yar@FreeBSD.ORG>
To: Gleb Smirnoff <glebius@cell.sick.ru>,
	FreeBSD-gnats-submit@FreeBSD.ORG, freebsd-bugs@FreeBSD.ORG
Cc:  
Subject: Re: kern/47920: if ng_pppoe switches to nonstandard mode it stays in it forever
Date: Tue, 9 Dec 2003 16:14:41 +0300

 I would rather change the name of the variable "nonstandard"
 to "pppoe_mode", not "standard", because lines like this one:
 
 	standard = PPPOE_NONSTANDARD;
 
 give me a schizoid feeling :-)
 
 I also believe you should not omit the "freebsd-gnats-submit@freebsd.org"
 address from the list of recipients when sending a follow-up to a PR, or
 else GNATS will not be able to add your follow-up to the audit trail.
 
 -- 
 Yar



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200312091320.hB9DK3YG093452>