From owner-freebsd-current@FreeBSD.ORG Thu Oct 22 14:17:32 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2C8971065672 for ; Thu, 22 Oct 2009 14:17:32 +0000 (UTC) (envelope-from bf1783@googlemail.com) Received: from mail-ew0-f209.google.com (mail-ew0-f209.google.com [209.85.219.209]) by mx1.freebsd.org (Postfix) with ESMTP id B1FC48FC1D for ; Thu, 22 Oct 2009 14:17:31 +0000 (UTC) Received: by ewy5 with SMTP id 5so4562842ewy.36 for ; Thu, 22 Oct 2009 07:17:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=EAeaGWWUUta3hYSL7b2lc2T9Q0Cri1GyOAggHJcwefc=; b=KDTLVQBvj5w0TKYMp5doTnvfSTg1sexbviyCsXu/4h43P4pAX2OTiUjs/yt8xCczrQ 6vLqVp9t6C+vmMzZJtzOGBYI/nAZJOxUKjTGUZZbJ1YGwYo8arQdVYo9dC0+eFw9qime A95zNC/SXAVQ9SxJ7f+Rzf66fH1SJNOfVZ8eo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=R+HVon3OC2jCQ1xpYzmHhAXGo0aumaAOOFF9MpodFmhc7S7qEDTe14uIgGftE6O/Ca yNH43D9Vk7KP8Xw4MyrHYJxs3w7AP8Zv06WXRSnoaEehsBg0Lns5kZyAMmDKUnRIQKXr PS7Z0c/u3aWd5+qQh1AP75OiXQr7kgsEFNqww= MIME-Version: 1.0 Received: by 10.216.93.70 with SMTP id k48mr3476913wef.134.1256221050574; Thu, 22 Oct 2009 07:17:30 -0700 (PDT) In-Reply-To: References: <9ace436c0910202052r1d1235dax774290a4fa1ee842@mail.gmail.com> Date: Thu, 22 Oct 2009 14:17:29 +0000 Message-ID: From: "b. f." To: "Li, Qing" Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-current@freebsd.org Subject: Re: svn commit: r198306 - head/sys/net X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Oct 2009 14:17:32 -0000 On 10/22/09, Li, Qing wrote: >> >> Perhaps not strictly necessary, but wouldn't it be better to have it? >> What is your rationale for not using making it conditional on SMP? >> > > If the definition itself is not within the preprocessor command, what > is the benefit of having it in the code ? > Do you mean what is the benefit of including the preprocessor commands? Well, in that case, because there is less unnecessary code to compile and traverse. If you mean to ask why sys/sys/smp.h was included unconditionally, to use smp_started and mp_maxid when they don't need to be used in the case of non-SMP kernels, then I'm guessing that the original author didn't really care all that much about efficiency in the non-SMP case, or at least that a unified treatment of SMP and non-SMP was more appealing to him, and I agree that further improvements could be made. b.