From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Dec 25 13:10:12 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8DD68106564A for ; Sun, 25 Dec 2011 13:10:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 48C5A8FC14 for ; Sun, 25 Dec 2011 13:10:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBPDACBL065298 for ; Sun, 25 Dec 2011 13:10:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBPDACq5065297; Sun, 25 Dec 2011 13:10:12 GMT (envelope-from gnats) Resent-Date: Sun, 25 Dec 2011 13:10:12 GMT Resent-Message-Id: <201112251310.pBPDACq5065297@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Panagiotis Christias Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 448A21065678 for ; Sun, 25 Dec 2011 13:02:10 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 2F7AC8FC15 for ; Sun, 25 Dec 2011 13:02:10 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pBPD29OS021172 for ; Sun, 25 Dec 2011 13:02:09 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id pBPD295w021171; Sun, 25 Dec 2011 13:02:09 GMT (envelope-from nobody) Message-Id: <201112251302.pBPD295w021171@red.freebsd.org> Date: Sun, 25 Dec 2011 13:02:09 GMT From: Panagiotis Christias To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/163606: [patch] lang/v8: make sure that CFLAGS always contains -fno-strict-aliasing X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Dec 2011 13:10:12 -0000 >Number: 163606 >Category: ports >Synopsis: [patch] lang/v8: make sure that CFLAGS always contains -fno-strict-aliasing >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Dec 25 13:10:11 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Panagiotis Christias >Release: 7.4-amd64 >Organization: NTUA NOC >Environment: FreeBSD builder7-amd64.noc.ntua.gr 7.4-RELEASE FreeBSD 7.4-RELEASE #0: Tue Apr 5 14:05:40 EEST 2011 root@thetis.noc.ntua.gr:/usr/obj/usr/src/sys/NTUA amd64 >Description: lang/v8 needs -fno-strict-aliasing to compile properly, so if CFLAGS is defined outside the port's Makefile (e.g. in /etc/make.conf) and does not contain -fno-strict-aliasing then default value of CFLAGS gets overwritten and building fails. Merry Christmas, Panagiotis >How-To-Repeat: Have something like "CFLAGS=-O -pipe" and try to build lang/v8: # echo "CFLAGS=-O -pipe" >> /etc/make.conf # cd /usr/ports/lang/v8 # make >Fix: See attached patch (could be done in a better way i suppose). Patch attached with submission follows: --- /usr/ports/lang/v8//Makefile.orig 2011-11-03 17:13:14.000000000 +0200 +++ /usr/ports/lang/v8//Makefile 2011-12-25 13:35:46.000000000 +0200 @@ -48,6 +48,14 @@ .elif ${ARCH} == amd64 V8ARCH=x64 .endif + +.if defined(CFLAGS) +CFLAGS:= ${CFLAGS:C/-fstrict-aliasing//} +.if empty(CFLAGS:M-fno-strict-aliasing) +CFLAGS+= -fno-strict-aliasing +.endif +.endif + PLIST_SUB+= ARCH=${V8ARCH} SCONS_ARGS+= arch=${V8ARCH} SCONS_BUILDENV+= CC="${CC} ${CFLAGS}" CXX="${CXX} ${CXXFLAGS}" >Release-Note: >Audit-Trail: >Unformatted: