From owner-freebsd-stable@FreeBSD.ORG Wed Oct 22 15:35:59 2008 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 227C610656A2 for ; Wed, 22 Oct 2008 15:35:59 +0000 (UTC) (envelope-from jdc@koitsu.dyndns.org) Received: from QMTA10.emeryville.ca.mail.comcast.net (qmta10.emeryville.ca.mail.comcast.net [76.96.30.17]) by mx1.freebsd.org (Postfix) with ESMTP id 023FD8FC08 for ; Wed, 22 Oct 2008 15:35:58 +0000 (UTC) (envelope-from jdc@koitsu.dyndns.org) Received: from OMTA06.emeryville.ca.mail.comcast.net ([76.96.30.51]) by QMTA10.emeryville.ca.mail.comcast.net with comcast id Vn6r1a00816AWCUAArbyFf; Wed, 22 Oct 2008 15:35:58 +0000 Received: from koitsu.dyndns.org ([69.181.141.110]) by OMTA06.emeryville.ca.mail.comcast.net with comcast id Vrbx1a00C2P6wsM8Srbywp; Wed, 22 Oct 2008 15:35:58 +0000 X-Authority-Analysis: v=1.0 c=1 a=BYaJvuN2rVMA:10 a=Ddka7i0Yzg4A:10 a=QycZ5dHgAAAA:8 a=iHYpvAsjCs-AlEUIP7oA:9 a=oE8heCWeMxJShmty2X42rIAAwt8A:4 a=EoioJ0NPDVgA:10 a=SV7veod9ZcQA:10 a=LY0hPdMaydYA:10 Received: by icarus.home.lan (Postfix, from userid 1000) id 937FDC9432; Wed, 22 Oct 2008 08:35:57 -0700 (PDT) Date: Wed, 22 Oct 2008 08:35:57 -0700 From: Jeremy Chadwick To: Eduardo Meyer Message-ID: <20081022153557.GA62088@icarus.home.lan> References: <20081022151228.GA60664@icarus.home.lan> <20081022152407.GA61546@icarus.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Cc: stable@freebsd.org, pluknet Subject: Re: Check if interface supports Device Polling X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2008 15:35:59 -0000 On Wed, Oct 22, 2008 at 01:30:57PM -0200, Eduardo Meyer wrote: > On Wed, Oct 22, 2008 at 1:24 PM, Jeremy Chadwick wrote: > > On Wed, Oct 22, 2008 at 08:12:28AM -0700, Jeremy Chadwick wrote: > >> > # ifconfig -v rl0 caps > >> > Capabilities: 48 > >> > >> The above patch is completely unnecessary. The -m flag in ifconfig > >> will do what you want. > >> > >> However, the existing ifconfig code does not print POLLING as a > >> capability, which is where the bug truly lies. > >> > >> I'll provide a patch that extends the capability list properly, and will > >> allow you to determine a full capability list. > > > > I'm both correct and incorrect. > > > > Correct: ifconfig -m will show you want. No need for the patch. > > > > Incorrect: I missed the "POLLING" part of #define IFCAPBITS in > > ifconfig.c -- it is in fact listed there. > > > > Maybe the polling bit is only made available if you've built a kernel > > with "option DEVICE_POLLING"? For example, I can do "ifconfig em1 > > polling", which returns no error, but "ifconfig -m em1" does not show > > POLLING. (My kernel does NOT have DEVICE_POLLING defined.) > > > > In your above output, capabilities is 0x48, which means POLLING is > > available, and VLAN_MTU is available. You did not provide us output of > > "ifconfig -m rl0", but I'd be inclined to believe "POLLING" is shown > > there... I hope. :-) > > > > Also, it appears ifconfig does not print TOE4 or TOE6 capability bits; > > that's probably a missing feature. > > > > -- > > | Jeremy Chadwick jdc at parodius.com | > > | Parodius Networking http://www.parodius.com/ | > > | UNIX Systems Administrator Mountain View, CA, USA | > > | Making life hard for others since 1977. PGP: 4BD6C0CB | > > > > > > You are right. My mistake, its there, in the "capabilities" line when > -m is issued. > > Thank you Jeremy. You're welcome. :-) Also, FWIW, PR 128295 has been filed to address the missing TOE4/TOE6 bits. -- | Jeremy Chadwick jdc at parodius.com | | Parodius Networking http://www.parodius.com/ | | UNIX Systems Administrator Mountain View, CA, USA | | Making life hard for others since 1977. PGP: 4BD6C0CB |