From owner-freebsd-current@freebsd.org Sat Aug 24 18:04:52 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 58C11C6234 for ; Sat, 24 Aug 2019 18:04:52 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46G5l64yBlz3xxJ for ; Sat, 24 Aug 2019 18:04:50 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x7OI4e7R037234 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 24 Aug 2019 21:04:43 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x7OI4e7R037234 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x7OI4e4c037233; Sat, 24 Aug 2019 21:04:40 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 24 Aug 2019 21:04:40 +0300 From: Konstantin Belousov To: Warner Losh Cc: Michael Butler , freebsd-current Subject: Re: SVN r351457 breaks drm-current Message-ID: <20190824180440.GD71821@kib.kiev.ua> References: <1ed2692e-9964-58f7-5af9-08fadf65dec7@protected-networks.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-Rspamd-Queue-Id: 46G5l64yBlz3xxJ X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kostikbel@gmail.com) smtp.mailfrom=kostikbel@gmail.com X-Spamd-Result: default: False [-2.97 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FREEMAIL_FROM(0.00)[gmail.com]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.975,0]; IP_SCORE(0.00)[ip: (-2.63), ipnet: 2001:470::/32(-4.44), asn: 6939(-3.06), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; FREEMAIL_ENVFROM(0.00)[gmail.com]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Aug 2019 18:04:52 -0000 On Sat, Aug 24, 2019 at 11:02:20AM -0600, Warner Losh wrote: > forward declaring struct pcpu; in md_var.h "fixes" this, but I'm not sure > that's the right fix. More correct way to fix it is to include sys/pcpu.h before machine/md_var.h, same as all in-tree consumers of the header do, apparently. But another question is why the driver needs md_var.h, there are no externally usable definitions there. > > Warner > > On Sat, Aug 24, 2019 at 10:35 AM Michael Butler > wrote: > > > As follows .. > > > > Building > > > > /usr/obj/usr/src/amd64.amd64/sys/TOSHI/modules/usr/local/sys/modules/drm-current-kmod/linuxkpi/linux_compat.o > > --- linux_compat.o --- > > In file included from > > > > /usr/local/sys/modules/drm-current-kmod/linuxkpi/gplv2/src/linux_compat.c:5: > > ./machine/md_var.h:61:34: error: declaration of 'struct pcpu' will not > > be visible outside of this function [-Werror,-Wvisibility] > > void amd64_bsp_pcpu_init1(struct pcpu *pc); > > ^ > > ./machine/md_var.h:63:32: error: declaration of 'struct pcpu' will not > > be visible outside of this function [-Werror,-Wvisibility] > > void amd64_bsp_ist_init(struct pcpu *pc); > > ^ > > > > imb > > _______________________________________________ > > freebsd-current@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > >