From owner-freebsd-current@FreeBSD.ORG  Thu May 14 07:42:25 2015
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 3B30EDB;
 Thu, 14 May 2015 07:42:25 +0000 (UTC)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
 by mx1.freebsd.org (Postfix) with ESMTP id EE95B1A8B;
 Thu, 14 May 2015 07:42:24 +0000 (UTC)
Received: from critter.freebsd.dk (unknown [192.168.48.2])
 by phk.freebsd.dk (Postfix) with ESMTP id C93833BD35;
 Thu, 14 May 2015 07:42:17 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
 by critter.freebsd.dk (8.14.9/8.14.9) with ESMTP id t4E7gFlm062512;
 Thu, 14 May 2015 07:42:16 GMT (envelope-from phk@phk.freebsd.dk)
To: John-Mark Gurney <jmg@funkthat.com>
cc: Ian Lepore <ian@freebsd.org>, Adrian Chadd <adrian@freebsd.org>,
 Hans Petter Selasky <hps@selasky.org>,
 David Chisnall <theraven@freebsd.org>,
 Baptiste Daroussin <bapt@freebsd.org>,
 "current@freebsd.org" <current@freebsd.org>
Subject: Re: Increase BUFSIZ to 8192
In-reply-to: <20150514072155.GT37063@funkthat.com>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
References: <20150511230635.GA46991@ivaldir.etoilebsd.net>
 <20150512032307.GP37063@funkthat.com> <14994.1431412293@critter.freebsd.dk>
 <20150513080342.GE37063@funkthat.com>
 <A1224018-7540-4C76-91EF-AEA2655E49A8@FreeBSD.org>
 <55530CC3.1090204@selasky.org> <1431528249.1221.15.camel@freebsd.org>
 <CAJ-VmonL9mT4JLqfSefKYiwv5-ecLkx9RZ5=kXt__+s9iO4+9Q@mail.gmail.com>
 <20150513181347.GM37063@funkthat.com> <1431542835.1221.30.camel@freebsd.org>
 <20150514072155.GT37063@funkthat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <62510.1431589335.1@critter.freebsd.dk>
Date: Thu, 14 May 2015 07:42:15 +0000
Message-ID: <62511.1431589335@critter.freebsd.dk>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 May 2015 07:42:25 -0000

--------
In message <20150514072155.GT37063@funkthat.com>, John-Mark Gurney writes:

>Since you apprently missed my original reply, I said that we shouldn't
>abuse BUFSIZ for this work, and that it should be changed in mdXhl.c...

Say what ?

BUFSIZ is used entirely appropriately in MDXFileChunk():  For reading
a file into an algorithm.

If in stead of open(2), fopen(3) had been used, the exact same thing
would happen, but using malloc space rather than stack space.


-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.