From owner-cvs-all@FreeBSD.ORG  Mon Jun 28 00:21:49 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1932316A4CE; Mon, 28 Jun 2004 00:21:49 +0000 (GMT)
Received: from fillmore.dyndns.org (port-212-202-50-15.dynamic.qsc.de
	[212.202.50.15])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id BFF5B43D48; Mon, 28 Jun 2004 00:21:48 +0000 (GMT)
	(envelope-from eikemeier@fillmore-labs.com)
Received: from [172.16.0.7] (helo=localhost)
	by fillmore.dyndns.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.34 (FreeBSD))
	id 1Bejtw-000O7c-ID; Mon, 28 Jun 2004 02:21:47 +0200
Date: Mon, 28 Jun 2004 02:21:53 +0200
Content-Type: text/plain; charset=US-ASCII; format=flowed
Mime-Version: 1.0 (Apple Message framework v482)
To: pav@FreeBSD.org
From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
In-Reply-To: <1088380914.969.10.camel@hood.oook.cz>
Message-Id: <28186290-C899-11D8-9FE1-00039312D914@fillmore-labs.com>
Content-Transfer-Encoding: 7bit
User-Agent: KMail/1.5.9
cc: Greg Lewis <glewis@eyesbeyond.com>
cc: cvs-ports@FreeBSD.org
cc: Kirill Ponomarew <krion@FreeBSD.org>
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/math/gnuplot Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Jun 2004 00:21:49 -0000

Pav Lucistnik wrote:

> In the unattended build, when no OPTIONS dialog is displayed, you don't
> have any WITH* and WITHOUT* variables set. Your port should behave as if
> default values were selected.
>
> OPTIONS=	OPTION "foo" on
>
> Default is to have OPTION on. When no WITH/WITHOUT* variables are
> generated, your test
>
> .if defined(WITH_OPTION)
>
> will fail. That's now the default you wanted. If you check instead
>
> .if !defined(WITHOUT_OPTION)
>
> it will work correctly in case OPTIONS were not processed. This nicely
> demonstrates in unattended build on packages on Bento, for example.

As a side note, generously changing WITH_* to WITHOUT_* breaks upgrading
for all people (like me) that use portupgrade to upgrade their ports.

Also, it might be intended to have a different set of options preselected
to choose from than those used for package building.

You should note changes like this at least in UPDATING.

-Oliver