From owner-freebsd-stable@freebsd.org Mon Oct 30 15:03:37 2017 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6CAE8E5F3FF for ; Mon, 30 Oct 2017 15:03:37 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from hz.grosbein.net (hz.grosbein.net [78.47.246.247]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id F2B856600D for ; Mon, 30 Oct 2017 15:03:36 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from eg.sd.rdtc.ru (root@eg.sd.rdtc.ru [62.231.161.221] (may be forged)) by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id v9UF3SiO073174 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Oct 2017 16:03:28 +0100 (CET) (envelope-from eugen@grosbein.net) X-Envelope-From: eugen@grosbein.net X-Envelope-To: mike@sentex.net Received: from eg.sd.rdtc.ru (eugen@localhost [127.0.0.1]) by eg.sd.rdtc.ru (8.15.2/8.15.2) with ESMTP id v9UF3MVg063800; Mon, 30 Oct 2017 22:03:22 +0700 (+07) (envelope-from eugen@grosbein.net) Subject: Re: ppp routing bug ? To: Mike Tancsa , FreeBSD-STABLE Mailing List References: <59F1B650.5070107@grosbein.net> <22c3cbd4-2a8e-884f-ec9b-cc4d12ff818f@sentex.net> <59F1EA48.1090500@grosbein.net> <59F206CB.5000006@grosbein.net> <98f44309-d706-4cef-c0b2-0f08e0e1855c@sentex.net> <59F25ED0.1010001@grosbein.net> <082408ba-b756-696f-5885-226e4ccbd2ea@sentex.net> From: Eugene Grosbein Message-ID: <59F73F3A.1090701@grosbein.net> Date: Mon, 30 Oct 2017 22:03:22 +0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <082408ba-b756-696f-5885-226e4ccbd2ea@sentex.net> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Status: Yes, score=5.5 required=5.0 tests=BAYES_00, DATE_IN_FUTURE_96_Q, LOCAL_FROM,RDNS_NONE autolearn=no autolearn_force=no version=3.4.1 X-Spam-Report: * 3.3 DATE_IN_FUTURE_96_Q Date: is 4 days to 4 months after Received: date * -2.3 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 2.6 LOCAL_FROM From my domains * 1.9 RDNS_NONE Delivered to internal network by a host with no rDNS X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on hz.grosbein.net X-Spam-Flag: YES X-Spam-Level: ***** X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 15:03:37 -0000 On 30.10.2017 20:57, Mike Tancsa wrote: > On 10/26/2017 6:16 PM, Eugene Grosbein wrote: >> >> That makes sense: ppp send bogus request to the routing socket and >> the request has not RTF_HOST flag nor RTA_NETMASK address. >> It seems, earlier kernel code masked this bug somehow but it does not now. >> >> Anyway, we have two bugs here: ppp sending bad request and kernel having >> no enough checks for this somehow. >> >> Fixing ppp part would be easy. Please try this patch: > > > Hi, Thanks again for the fix. > Any chance of committing this to HEAD and then an MFC ? Committed with r325157, will MFC in a week.