From owner-freebsd-stable@FreeBSD.ORG  Wed Jan 16 16:15:09 2013
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 8444E3DC;
 Wed, 16 Jan 2013 16:15:09 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net
 [IPv6:2001:7b8:2ff:146::2])
 by mx1.freebsd.org (Postfix) with ESMTP id 477FF692;
 Wed, 16 Jan 2013 16:15:09 +0000 (UTC)
Received: from [IPv6:2001:7b8:3a7:0:84a:f2c4:59a0:2557] (unknown
 [IPv6:2001:7b8:3a7:0:84a:f2c4:59a0:2557])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by tensor.andric.com (Postfix) with ESMTPSA id E09685C37;
 Wed, 16 Jan 2013 17:15:07 +0100 (CET)
Message-ID: <50F6D20A.6070306@FreeBSD.org>
Date: Wed, 16 Jan 2013 17:15:06 +0100
From: Dimitry Andric <dim@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:18.0) Gecko/20121128 Thunderbird/18.0
MIME-Version: 1.0
To: Kimmo Paasiala <kpaasial@gmail.com>
Subject: Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9
References: <CA+7WWSeOpuAv9PL2_G6Z1Q_SLv5xcTjcujiw6Rs8tdBsrLO7wQ@mail.gmail.com>
In-Reply-To: <CA+7WWSeOpuAv9PL2_G6Z1Q_SLv5xcTjcujiw6Rs8tdBsrLO7wQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Brooks Davis <brooks@freebsd.org>, freebsd-stable@freebsd.org
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Jan 2013 16:15:09 -0000

On 2013-01-16 13:05, Kimmo Paasiala wrote:
> I just updated my stable/9 system after clang3.2 was added. My system
> is amd64, both world and kernel are compiled with clang3.2 and the
> default compiler is clang. I'm tracking the sources with GIT and the
> version I have corresponds to SVN revision r245451.
>
> Everything else seems to work but the pam authentication module
> security/pam_ssh_agent_auth segfaults immediately.
...
> #0  0x0000000800ef2070 in strsvis () from /lib/libc.so.7
> #1  0x0000000800ef2584 in strvis () from /lib/libc.so.7
> #2  0x0000000800ef25e5 in strnvis () from /lib/libc.so.7
> #3  0x0000000801c0e2e7 in do_log () from /usr/local/lib/pam_ssh_agent_auth.so
> #4  0x0000000801c0e4ff in logit () from /usr/local/lib/pam_ssh_agent_auth.so
...
> The str*vis() calls suggest that it's something in the libc maybe?

Brooks merged the new strvis implementations in r245439, so you may have
run into a bug with them.  I don't think this is caused specifically by
clang, at least not without more proof. :-)

Can you try reverting to the revision just before r245439, rebuilding
and reinstalling at least libc, and see if the pam_ssh_agent_auth crash
goes away?