From owner-svn-ports-head@FreeBSD.ORG Sun Sep 8 15:39:33 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 0C209EE for ; Sun, 8 Sep 2013 15:39:33 +0000 (UTC) (envelope-from oliver@freebsd.org) Received: from avocado.salatschuessel.net (avocado.salatschuessel.net [78.111.72.186]) by mx1.freebsd.org (Postfix) with ESMTP id 6EA7C239B for ; Sun, 8 Sep 2013 15:39:31 +0000 (UTC) Received: (qmail 63660 invoked by uid 80); 8 Sep 2013 15:39:30 -0000 Received: from dsdf-4db5f100.pool.mediaWays.net (dsdf-4db5f100.pool.mediaWays.net [77.181.241.0]) by avocado.salatschuessel.net (Horde Framework) with HTTP; Sun, 08 Sep 2013 17:39:30 +0200 Date: Sun, 08 Sep 2013 17:39:30 +0200 Message-ID: <20130908173930.Horde.pCVXzy4T-cXp8PC2LonKxg2@avocado.salatschuessel.net> From: Oliver Lehmann To: Alexey Dokuchaev Subject: Re: svn commit: r326685 - in head: devel/mercator math/wfmath References: <201309072043.r87KhjYi068970@svn.freebsd.org> <20130908033306.GA54749@FreeBSD.org> <20130908115253.Horde.idQUkFxUdsyF3rNQX9eeBA2@avocado.salatschuessel.net> <20130908145110.GB46281@FreeBSD.org> In-Reply-To: <20130908145110.GB46281@FreeBSD.org> User-Agent: Internet Messaging Program (IMP) H5 (6.1.4) Content-Type: text/plain; charset=UTF-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Sep 2013 15:39:33 -0000 Alexey Dokuchaev wrote: >> >2) why is it hard to create a proper patch instead; >> >> Why? I can't tell, I'm sorry - I just was not able to fix the clang >> compilation problems otherwise. > > Again, it's hard to understand that without the documenting why USE_GCC was > used in the first place. Second, given the suggestion of simply removing > misused CONFIGURE_ARGS (and provided that it does indeed solve the issue), > I find it a bit hard to believe you could not have come up with it yourself > Oliver. ;-) devel/mercator got USE_GCC as otherwise it wouldn't compile with a gcc-compiled math/wfmath. And math/wfmath got USE_GCC as I'm not able to fix those issues: http://beefy1.isc.freebsd.org/bulk/head-default/2013-09-04_23h56m58s/logs/wfmath-1.0.1.log math/wfmath has no CONFIGURE_ARGS to remove (devel/mercator has). >> >3) is it really necessary to set USE_GCC to "yes", not "any"? >> >> This is what the header of bsd.gcc.mk suggests. If "any" is prefered over >> "yes", it should be stated somewhere in the top of bsd.gcc.mk - maybe in >> the Examples section which is where I always look first. > > "yes" and "any" do different things, it's not the matter of style. "yes" > means to use modern GCC compiler, even on systems that still use GCC as > a system one by default (e.g. 8.x, 9.x). "any" means that literally any > GCC version would suffice, which means that on our stable branches, I do > not have to install some GCC 4.6+ since I already gave GCC 4.2 in the base. I looked the differenc between "any" and "yes"t already up after you told me about "any" the first time by searching bsd.gcc.mk. I still think that it would be better to have "any" also documented in bsd.gcc.mk at the top. Maybe in the Examples section - how should anyone know about the two switches and their meanings? Greetings Oliver