Date: Sat, 12 May 2018 10:12:33 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Ian Lepore <ian@freebsd.org> Cc: "Jonathan T. Looney" <jtl@freebsd.org>, Stephen Hurd <shurd@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r333503 - stable/11/sys/net Message-ID: <20180512100335.B1840@besplex.bde.org> In-Reply-To: <1526081817.2597.5.camel@freebsd.org> References: <201805112040.w4BKeQvO053076@repo.freebsd.org> <CADrOrmuKJvUh7C_Y=KtG9WBtsQvaQHJ7=CFYjtvPKbrc=r1GMg@mail.gmail.com> <1526081817.2597.5.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 11 May 2018, Ian Lepore wrote: > On Fri, 2018-05-11 at 19:31 -0400, Jonathan T. Looney wrote: >> On Fri, May 11, 2018 at 4:40 PM, Stephen Hurd <shurd@freebsd.org> wrote: >>> >>> >>> Author: shurd >>> Date: Fri May 11 20:40:26 2018 >>> New Revision: 333503 >>> URL: https://svnweb.freebsd.org/changeset/base/333503 >>> >>> Log: >>> =A0 MFC r333329, r333366, r333373 >>> >>> =A0 r333329: Fix off-by-one error requesting tx interrupt >>> =A0 r333366: Cleanup queues when iflib_device_register fails >>> =A0 r333373: Log iflib_tx_structures_setup failure in function >>> >> Is this an acceptable style for MFC logs? >> >> I'm asking because I actually prefer this to reading (or compiling) the >> concatenated log messages from several changes. However, I never knew it >> was acceptable to summarize like this. If it is, I'd like to know so I c= an >> adopt it for run-of-the-mill MFCs. >> >> Jonathan > > This used to be my preferred format, essentially to summarize what's > being mfc'd. But then I started using the MFC Tracker tool [*] and it > automatically generates a commit message that contains the full text, > so I stopped trying to summarize things. > > [*]=A0https://mfc.kernelnomicon.org/6/ It was the normal style with cvs (to avoid spamming the repository as well as readers). Howver, one of many worse behaviours in svn is that after checking out a branch, svn log only shows history for the branch, so it is hard to find the full log messages even if you know that the visible ones are only summaries. Bruce From owner-svn-src-stable-11@freebsd.org Sat May 12 00:17:53 2018 Return-Path: <owner-svn-src-stable-11@freebsd.org> Delivered-To: svn-src-stable-11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 27ABBFD670A for <svn-src-stable-11@mailman.ysv.freebsd.org>; Sat, 12 May 2018 00:17:53 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com [IPv6:2607:f8b0:4001:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A46807DDEA for <svn-src-stable-11@freebsd.org>; Sat, 12 May 2018 00:17:52 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22b.google.com with SMTP id e78-v6so8936915iod.0 for <svn-src-stable-11@freebsd.org>; Fri, 11 May 2018 17:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=QWgzeorpigwh9yNCMi6v4B5uZhvV6Po2yZnXpj3hPwQ=; b=NtUf5+UeMDMepKJ4jQB1ZjJrs+zpc/DWBLHUqP3ZhqZ2O/2gK80DL9mz7ixN71x0hK csa19wTtg5k0p6wlC2Dk4/Se/1mxFy2Jjspdfjc72myvZECHB4vLQP4XTh3e8VkqXXqv aZafjbLRcTofgUQ76I3pXddNJSm8tps7sSPzdmPewgx3IA6jxBsbd5cWBlPeJTrPM7Lw 0NNjQ0156xFz2UzVLxyb6sP0+bDXqWG54ttcx4b03MAhtmRQf67Wa97bTFLl/korLqa2 0QvHM7NcShLo1CEhchueKT9hdhkkx6xmwn6DpRIEotkAXpr7mbAKb1F5dTZcLg+YqWB9 ml6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=QWgzeorpigwh9yNCMi6v4B5uZhvV6Po2yZnXpj3hPwQ=; b=AIvfUTLceCG+Db8fWKESN9FiD+z9/klf6tZFGKV/4ktF9ARZ/mfIXy/WCGI51WNht+ VQyq9PVxQA4PCL+9aKrio5aMdo3XxTJcpQxpaSposcjHbmdPC4BwEkq0IgZUok5y8iFr oKqeq5fJ/rvSyR3NyuejXNONyBEDGAz7zwOKNtpAHJ9iVTKrUMl2G0RcoelT4f9b3jWG RHOFTsr7qA+FCTFF6E381QSv5WkHn2nrtA/6nLDxnJIOJVetswParNjieFZgpx0hK17G jJCD/osnnJ8bYm4OWIP8ogXU3lS8Sl/K00fE9hg+kN4ixnjyWYqbyiE4UY+84RzLy5Gy 7t+A== X-Gm-Message-State: ALKqPwePRq68eYKfN8aYK2u0vgeTO8opxB7+pT4+3xzP3wM6LpxHJWdr xnlcX09Sn3F/jxN4wSQbL+riYS8SvuuwG7nv4arMrw== X-Google-Smtp-Source: AB8JxZo7j0Al2IOw8iQa8LpVoV/ZQaWZH4VFp67teIJZf+CQNQUemYYKROQr5GbxJMRLPMLJ7Q5g9l3SiGaRRrDuCk0= X-Received: by 2002:a6b:12a3:: with SMTP id 35-v6mr591687ios.168.1526084271784; Fri, 11 May 2018 17:17:51 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:a649:0:0:0:0:0 with HTTP; Fri, 11 May 2018 17:17:51 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <CADrOrmuKJvUh7C_Y=KtG9WBtsQvaQHJ7=CFYjtvPKbrc=r1GMg@mail.gmail.com> References: <201805112040.w4BKeQvO053076@repo.freebsd.org> <CADrOrmuKJvUh7C_Y=KtG9WBtsQvaQHJ7=CFYjtvPKbrc=r1GMg@mail.gmail.com> From: Warner Losh <imp@bsdimp.com> Date: Fri, 11 May 2018 18:17:51 -0600 X-Google-Sender-Auth: 8QNEvPLqo5aW5VmOIG3Q2jG0Jcc Message-ID: <CANCZdfoK6Le-Qnpfp+rXOVOCdneSg1TedWfxkHoc43UChJo_Ow@mail.gmail.com> Subject: Re: svn commit: r333503 - stable/11/sys/net To: "Jonathan T. Looney" <jtl@freebsd.org> Cc: Stephen Hurd <shurd@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-stable-11@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for only the 11-stable src tree <svn-src-stable-11.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-stable-11>, <mailto:svn-src-stable-11-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable-11/>; List-Post: <mailto:svn-src-stable-11@freebsd.org> List-Help: <mailto:svn-src-stable-11-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-stable-11>, <mailto:svn-src-stable-11-request@freebsd.org?subject=subscribe> X-List-Received-Date: Sat, 12 May 2018 00:17:53 -0000 On Fri, May 11, 2018 at 5:31 PM, Jonathan T. Looney <jtl@freebsd.org> wrote: > On Fri, May 11, 2018 at 4:40 PM, Stephen Hurd <shurd@freebsd.org> wrote: > > > > Author: shurd > > Date: Fri May 11 20:40:26 2018 > > New Revision: 333503 > > URL: https://svnweb.freebsd.org/changeset/base/333503 > > > > Log: > > MFC r333329, r333366, r333373 > > > > r333329: Fix off-by-one error requesting tx interrupt > > r333366: Cleanup queues when iflib_device_register fails > > r333373: Log iflib_tx_structures_setup failure in function > > > > Is this an acceptable style for MFC logs? > > I'm asking because I actually prefer this to reading (or compiling) the > concatenated log messages from several changes. However, I never knew it > was acceptable to summarize like this. If it is, I'd like to know so I can > adopt it for run-of-the-mill MFCs. > Unless there's a compelling reason to not do it, it is totally fine. I used to do mega-nanobsd MFCs exactly like this (though I may have include author of original commit sometimes). In general, anything is an acceptable style for MFC. The project hasn't set a style, and the variation between committers is large. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180512100335.B1840>