Date: Sun, 23 Feb 2014 22:56:02 +0000 From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: Craig Rodrigues <rodrigc@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r262351 - head/sys/netinet6 Message-ID: <D23407A9-35AC-4B5A-904D-B1BD333B46C0@FreeBSD.org> In-Reply-To: <201402230127.s1N1RMoX052542@svn.freebsd.org> References: <201402230127.s1N1RMoX052542@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 23 Feb 2014, at 01:27 , Craig Rodrigues <rodrigc@FreeBSD.org> wrote: > Author: rodrigc > Date: Sun Feb 23 01:27:22 2014 > New Revision: 262351 > URL: http://svnweb.freebsd.org/changeset/base/262351 >=20 > Log: > Remove KASSERT from in6p_lookup_mcast_ifp(). >=20 > When the devel/jenkins port, version 1.551 was started, > the kernel would panic if INVARIANTS was enabled in the kernel = config. >=20 > Suggested by: bms This reads to me =93we hit the assert, bms suggested to remove it=94. = Great! Caught a bug! Where is it? In no way the commit message tells = me why? Why did we not hit the assert in the last n years? What has = changed that we hit it now? Was the assert wrong from the beginning? = Did we hit a real bug elsewhere and now lost the tracking for it? Could you please at least for the archives explain? >=20 > Modified: > head/sys/netinet6/in6_mcast.c >=20 > Modified: head/sys/netinet6/in6_mcast.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/netinet6/in6_mcast.c Sun Feb 23 00:46:05 2014 = (r262350) > +++ head/sys/netinet6/in6_mcast.c Sun Feb 23 01:27:22 2014 = (r262351) > @@ -1781,8 +1781,6 @@ in6p_lookup_mcast_ifp(const struct inpcb > ("%s: not INP_IPV6 inpcb", __func__)); > KASSERT(gsin6->sin6_family =3D=3D AF_INET6, > ("%s: not AF_INET6 group", __func__)); > - KASSERT(IN6_IS_ADDR_MULTICAST(&gsin6->sin6_addr), > - ("%s: not multicast", __func__)); >=20 > ifp =3D NULL; > memset(&ro6, 0, sizeof(struct route_in6)); =97=20 Bjoern A. Zeeb ????????? ??? ??????? ??????: '??? ??? ???? ?????? ??????? ?? ?? ??????? ??????? ??? ????? ????? ???? ?????? ?? ????? ????', ????????? ?????????, "??? ????? ?? ?????", ?.???
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D23407A9-35AC-4B5A-904D-B1BD333B46C0>