Date: Sat, 11 Mar 2017 13:19:16 -0600 From: Karl Denninger <karl@denninger.net> To: freebsd-arm@freebsd.org Subject: Re: Odd-looking serial console prompt on RPI2 Message-ID: <ed5b8c65-adbf-ef39-39a4-d1030541bb9c@denninger.net> In-Reply-To: <1489259878.40576.62.camel@freebsd.org> References: <20170302000334.GA99403@www.zefox.net> <1488419304.60166.26.camel@freebsd.org> <20170302020116.GA98466@bluezbox.com> <1488420309.60166.32.camel@freebsd.org> <CA%2B7sy7Bv=-2mx2MJP18ZnbNp2yO2hKukw=KALn711txaxsk=rg@mail.gmail.com> <1488664965.69705.24.camel@freebsd.org> <20170307190937.r7n45xj67tnhevv4@mutt-hbsd> <20170307192918.2garie2ow6lzekg7@mutt-hbsd> <20170311174940.bze4k7ndjdemmu4l@mutt-hbsd> <1489255444.40576.57.camel@freebsd.org> <20170311180947.ro5obisuaemvudkp@mutt-hbsd> <1489259878.40576.62.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a cryptographically signed message in MIME format. --------------ms020604080404060700000807 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 3/11/2017 13:17, Ian Lepore wrote: > On Sat, 2017-03-11 at 13:09 -0500, Shawn Webb wrote: >> On Sat, Mar 11, 2017 at 11:04:04AM -0700, Ian Lepore wrote: >>> On Sat, 2017-03-11 at 12:49 -0500, Shawn Webb wrote: >>>> On Tue, Mar 07, 2017 at 02:29:18PM -0500, Shawn Webb wrote: >>>>> >>>>> On Tue, Mar 07, 2017 at 02:09:37PM -0500, Shawn Webb wrote: >>>>>> >>>>>> On Sat, Mar 04, 2017 at 03:02:45PM -0700, Ian Lepore wrote: >>>>>>> >>>>>>> The bugs should be fixed as of r314682. ?It looks like the >>>>>>> bugs >>>>>>> have >>>>>>> long been in the pl011 driver, but were masked by having a >>>>>>> fifo >>>>>>> depth >>>>>>> of 1 byte -- it all sorta worked by accident previously. >>>>>> Thanks for the fix! But it looks to be only partial. When I >>>>>> connect to >>>>>> the serial console via either cu or screen, I don't get >>>>>> corrupted >>>>>> text, >>>>>> but no keypresses are registered. Hitting enter at the login >>>>>> prompt does >>>>>> absolutely nothing. I'm at the latest commit of >>>>>> hardened/current/master >>>>>> on HardenedBSD for both the RPI3 and my laptop. >>>>>> >>>>>> I'm using this serial cable from Adafruit: >>>>>> https://www.adafruit.com/product/954 >>>>> It looks like I had a bad cable. Sorry for the line noise. >>>>> Switching to >>>>> a different cable worked. >>>> Looks like the problem is back, but manifest in a different way. >>>> Screenshot: >>>> >>>> https://goo.gl/photos/XYx6v1jCTVCGrnhd6 >>>> >>>> Thanks, >>>> >>> I wonder if rpi3 needs the same smaller-fifo fix as a 32-bit rpi. >>> ?Just >>> to test that theory, can you see if the attached patch fixes >>> problem? >>> ?If it does, I'll figure out how to detect rpi3 at runtime and set >>> the >>> sizes properly. >>> >>> -- Ian >>> >>> Index: sys/dev/uart/uart_dev_pl011.c >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> --- sys/dev/uart/uart_dev_pl011.c (revision 314917) >>> +++ sys/dev/uart/uart_dev_pl011.c (working copy) >>> @@ -464,7 +464,7 @@ uart_pl011_bus_probe(struct uart_softc *sc) >>> is_bcm2835 =3D ofw_bus_is_compatible(sc->sc_dev, >>> "brcm,bcm2835-pl011") || >>> ofw_bus_is_compatible(sc->sc_dev, "broadcom,bcm2835- >>> uart"); >>> #else >>> - is_bcm2835 =3D false; >>> + is_bcm2835 =3D true; >>> #endif >>> hwrev =3D __uart_getreg(&sc->sc_bas, UART_PIDREG_2) >> 4; >>> if (hwrev <=3D 2 || is_bcm2835) { >> Sure. I'll report back either tonight or tomorrow. >> >> Thanks, >> > Actually, I think a proper solution will be something like the attached= > patch. After some spelunking on the web I think the rpi3 fifos are the= > smaller size because the fdt data contains the linux-style workaround > (which overrides the primecell periphid value with fdt data). This > patch looks for that in addition to looking for the rpi compatible > strings (still required to handle old-style freebsd fdt data). > > -- Ian > > > _______________________________________________ > freebsd-arm@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-arm > To unsubscribe, send any mail to "freebsd-arm-unsubscribe@freebsd.org" I can build for and test both the RPI2 and 3 if you'd like on serial console; I have both sitting here on my workbench. Just tell me which rev to check out and what to patch on it. --=20 Karl Denninger karl@denninger.net <mailto:karl@denninger.net> /The Market Ticker/ /[S/MIME encrypted email preferred]/ --------------ms020604080404060700000807 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgMFADCABgkqhkiG9w0BBwEAAKCC BlwwggZYMIIEQKADAgECAgE9MA0GCSqGSIb3DQEBCwUAMIGQMQswCQYDVQQGEwJVUzEQMA4G A1UECBMHRmxvcmlkYTESMBAGA1UEBxMJTmljZXZpbGxlMRkwFwYDVQQKExBDdWRhIFN5c3Rl bXMgTExDMRwwGgYDVQQDExNDdWRhIFN5c3RlbXMgTExDIENBMSIwIAYJKoZIhvcNAQkBFhND dWRhIFN5c3RlbXMgTExDIENBMB4XDTE2MTIxODE5NDUzNVoXDTIxMTIxNzE5NDUzNVowVzEL MAkGA1UEBhMCVVMxEDAOBgNVBAgTB0Zsb3JpZGExGTAXBgNVBAoTEEN1ZGEgU3lzdGVtcyBM TEMxGzAZBgNVBAMUEmthcmxAZGVubmluZ2VyLm5ldDCCAiIwDQYJKoZIhvcNAQEBBQADggIP ADCCAgoCggIBAM2N5maxs7NkoY9g5NMxFWll0TYiO7gXrGZTo3q25ZJgNdPMwrntLz/5ewE9 07TEbwJ3ah/Ep9BfZm7JF9vTtE1HkgKtXNKi0pawNGm1Yn26Dz5AbUr1byby6dFtDJr14E07 trzDCtRRvTkOVSBj6PQPal0fAnDtkIYQBVcuMkXkuMCtyfE95pjm8g4K9l7lAcKii3T1/3rE hCc1o2nBnb7EN1/XwBeCDGB+I2SN/ftZDbKQqGAF5q9dUn+iXU7Z/CVSfUWmhVh6cVZA4Ftv TglUqj410OuPx+cUQch3h1kFgsuhQR63HiJc3HbRJllHsV0rihvL1CjeARQkhnA6uY9NLFST p5I/PfzBzW2MSmtN/tGZvmfKKnmtbfUNgkzbIR1K3lsum+yEL71kB93Xtz/4f1demEx5c8TJ RBIniDHjDeLGK1aoBu8nfnvXAvgthFNTWBOEoR49AHEPjC3kZj0l8JQml1Y8bTQD5gtC5txl klO60WV0EufU7Hy9CmynMuFtjiA2v71pm097rXeCdrAKgisdYeEESB+SFrlY65rLiLv4n8o1 PX7DqRfqKkOYIakZ0ug/yHVKcq2EM3RiJxwzls5gT70CoOBlKbrC98O8TA6teON0Jq30M06t NTI2HhvNbJDLbBH+Awf4h1UKB+0ufENwjVvF5Jfz8Ww/FaSDAgMBAAGjgfQwgfEwNwYIKwYB BQUHAQEEKzApMCcGCCsGAQUFBzABhhtodHRwOi8vY3VkYXN5c3RlbXMubmV0Ojg4ODgwCQYD VR0TBAIwADARBglghkgBhvhCAQEEBAMCBaAwCwYDVR0PBAQDAgXgMCwGCWCGSAGG+EIBDQQf Fh1PcGVuU1NMIEdlbmVyYXRlZCBDZXJ0aWZpY2F0ZTAdBgNVHQ4EFgQUpfAI3y+751pp9A0w 6vJHx8RoR/MwHwYDVR0jBBgwFoAUJHGbnYV9/N3dvbDKkpQDofrTbTUwHQYDVR0RBBYwFIES a2FybEBkZW5uaW5nZXIubmV0MA0GCSqGSIb3DQEBCwUAA4ICAQBiB6MlugxYJdccD8boZ/u8 d8VxmLkJCtbfyYHRjYdyoABLW5hE3k3xSpYCM9L7vzWyV/UWwDYKi4ZzxHo4g+jG/GQZfKhx v38BQjL2G9xD0Hn2d+cygOq3UPjVYlbbfQoew6JbyCFXrrZ7/0jvRMLAN2+bRC7ynaFUixPH Whnj9JSH7ieYdzak8KN+G2coIC2t2iyfXVKehzi5gdNQ0vJ7+ypbGsRm4gE8Mdo9N/WgFPvZ HPFqR9Dwas7Z+aHwOabpk5r/336SyjOaZsn3MqKJQZL6GqDKusVOCWt+9uFAD8kadg7FetZe atIoD9I+zbp59oVoMnkMDMx7Hi85faU03csusqMGsjSsAzWSI1N8PJytZlchLiykokLKc3OL G87QKlErotlou7cfPX2BbEAH5wmkj9oiqZhxIL/wwAUA+PkiTbEmksKBNompSjUq/6UsR8EA s74gnu17lmijv8mrg2qMlwRirE7qG8pnE8egLtCDxcjd0Of9WMi2NJskn0/ovC7P+J60Napl m3ZIgPJst1piYSE0Zc1FIat4fFphMfK5v4iLblo1tFSlkdx1UNDGdg/U+LaXkNVXlMp8fyPm R80V6cIrCAlEWnBJNxG1UyfbbsvNMCCZBM4faGGsR/hhQOiydlruxhjL6P8J2WV8p11DdeGx KymWoil2s1J5WTGCBRMwggUPAgEBMIGWMIGQMQswCQYDVQQGEwJVUzEQMA4GA1UECBMHRmxv cmlkYTESMBAGA1UEBxMJTmljZXZpbGxlMRkwFwYDVQQKExBDdWRhIFN5c3RlbXMgTExDMRww GgYDVQQDExNDdWRhIFN5c3RlbXMgTExDIENBMSIwIAYJKoZIhvcNAQkBFhNDdWRhIFN5c3Rl bXMgTExDIENBAgE9MA0GCWCGSAFlAwQCAwUAoIICTTAYBgkqhkiG9w0BCQMxCwYJKoZIhvcN AQcBMBwGCSqGSIb3DQEJBTEPFw0xNzAzMTExOTE5MTZaME8GCSqGSIb3DQEJBDFCBEC7U0Gp yQsAlpNmf0Tfpoa5eiv0AK1yFl/+GJ092Djhevu8qzvqaotueW9peRHZyBLFVvdbn03mGz3q 3pSwG9v6MGwGCSqGSIb3DQEJDzFfMF0wCwYJYIZIAWUDBAEqMAsGCWCGSAFlAwQBAjAKBggq hkiG9w0DBzAOBggqhkiG9w0DAgICAIAwDQYIKoZIhvcNAwICAUAwBwYFKw4DAgcwDQYIKoZI hvcNAwICASgwgacGCSsGAQQBgjcQBDGBmTCBljCBkDELMAkGA1UEBhMCVVMxEDAOBgNVBAgT B0Zsb3JpZGExEjAQBgNVBAcTCU5pY2V2aWxsZTEZMBcGA1UEChMQQ3VkYSBTeXN0ZW1zIExM QzEcMBoGA1UEAxMTQ3VkYSBTeXN0ZW1zIExMQyBDQTEiMCAGCSqGSIb3DQEJARYTQ3VkYSBT eXN0ZW1zIExMQyBDQQIBPTCBqQYLKoZIhvcNAQkQAgsxgZmggZYwgZAxCzAJBgNVBAYTAlVT MRAwDgYDVQQIEwdGbG9yaWRhMRIwEAYDVQQHEwlOaWNldmlsbGUxGTAXBgNVBAoTEEN1ZGEg U3lzdGVtcyBMTEMxHDAaBgNVBAMTE0N1ZGEgU3lzdGVtcyBMTEMgQ0ExIjAgBgkqhkiG9w0B CQEWE0N1ZGEgU3lzdGVtcyBMTEMgQ0ECAT0wDQYJKoZIhvcNAQEBBQAEggIAbWv5SPKl65Iz osJJXgWokLgnGVHag/l3tt2qaRSSnjrI7eBihXBgBV0mLN+M8gnFpjNZ69by4+qXndPD6Qy1 hUQqA1B3X+LbPI1jnbFyvB0jF68BQ617BKe/HNlfIOdNKIHS/70PY0bnm4u1fr7DaW60MiZ1 tAaEjYv+giHS53smpDGnonIUO4mANIrdgwonYlif58OzvKQ+rNBCR0pNSnEutmeP9aEUIsJm pWD/3kHiyqsIPGVkrP2Zl75g6N7z16ScJX8A+Rm3fcY48uQdKPov5IMzU5qI/lu5OmLxS0xP QM+rGlUDNJueZ419O1X7R8rH/Fnc8tD1PukEnRTJRpa5M0jBIS9al5yGaC75MdrDbWumIxAy eVlfCOfvmW8V/sbudvE5+UlFec6GmfrRWWpSfkG91QYCX450URNGDMN+95M7+IvRWKQudPsj v82b/9pPXfsDX18BoCa8eX2LdsWc+auNtL+ZX9zhfxfXnr5OULl4nAiR0YvAZ9k5Z0tBCOYH e1lJpDE10Uz/gy5CT5GlSgKwy+/rbU1s4Ri8tx/cGRgoKHlXKoq8t5Ct7Gju63tfbHFA4gVg w4CVkXn/k3qMYqsLRwZs/hTc9393vkrFylXyTu1vd4sCfa81Bua7SlIrQMEcShMp0bU8OGY/ pom3Ou13e44n23FjZ6PhV4AAAAAAAAA= --------------ms020604080404060700000807--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ed5b8c65-adbf-ef39-39a4-d1030541bb9c>