From owner-freebsd-hackers@FreeBSD.ORG Tue Oct 14 16:35:38 2014 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8A7C9659 for ; Tue, 14 Oct 2014 16:35:38 +0000 (UTC) Received: from mail.michaelwlucas.com (mail.michaelwlucas.com [108.61.84.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4AA9A3A0 for ; Tue, 14 Oct 2014 16:35:38 +0000 (UTC) Received: from mail.michaelwlucas.com (localhost [127.0.0.1]) by mail.michaelwlucas.com (8.14.7/8.14.7) with ESMTP id s9EGZWPT026530; Tue, 14 Oct 2014 12:35:32 -0400 (EDT) (envelope-from mwlucas@mail.michaelwlucas.com) Received: (from mwlucas@localhost) by mail.michaelwlucas.com (8.14.7/8.14.7/Submit) id s9EGZWLJ026529; Tue, 14 Oct 2014 12:35:32 -0400 (EDT) (envelope-from mwlucas) Date: Tue, 14 Oct 2014 12:35:31 -0400 From: "Michael W. Lucas" To: "Michael W. Lucas" Subject: Re: GBDE not protecting the user Message-ID: <20141014163531.GB26488@mail.michaelwlucas.com> References: <20141010215842.GA6717@mail.michaelwlucas.com> <20141011113008.705ba16d@X220.alogt.com> <20141011074412.GA9432@mail.michaelwlucas.com> <54394A03.6060403@freebsd.org> <20141011175944.GA11131@mail.michaelwlucas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141011175944.GA11131@mail.michaelwlucas.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.michaelwlucas.com Cc: freebsd-hackers@freebsd.org X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Oct 2014 16:35:38 -0000 On Sat, Oct 11, 2014 at 01:59:44PM -0400, Michael W. Lucas wrote: > On Sat, Oct 11, 2014 at 11:17:23AM -0400, Allan Jude wrote: > > Michael: please file a PR on this now that it is confirmed, and together > > we can nag someone to fix it. > > Fair enough. > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194304 Following up on my own bug report: This seems to be a generic GBDE error message breakage. Here I change key 0's passphrase and key file. # gbde setkey da0p1 -n 0 -l da0p1.lock -k rat.jpg -L da0p1.lock-new Enter passphrase: Opened with key 0 Enter new passphrase: Reenter new passphrase: I now have a new lock file with a new passphrase. Let's try the old key file and see what happens. It appears to work, except it doesn't. # gbde attach da0p1 -l da0p1.lock -k rat.jpg Enter passphrase: # ls /dev/da0p1* /dev/da0p1 # gbde detach da0p1 gbde: Detach of da0p1 failed: Geom not found: "da0p1.bde" The new lock file and passphrase do work. I would have expected the attach command to call me an idiot rather than fail silently. An ignorant, uneducated, non-programmer look at the code encourages my belief. Bug report updated. ==ml -- Michael W. Lucas - mwlucas@michaelwlucas.com, Twitter @mwlauthor http://www.MichaelWLucas.com/, http://blather.MichaelWLucas.com/