Date: Wed, 21 Feb 2018 22:03:47 -0500 From: Alexander Motin <mav@FreeBSD.org> To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-vendor@freebsd.org Subject: Re: svn commit: r329770 - vendor-sys/illumos/dist/uts/common/fs/zfs/lua Message-ID: <56dda9e2-e9ea-83b9-1e54-6569d478615a@FreeBSD.org> In-Reply-To: <201802220104.w1M14uHQ088614@pdx.rh.CN85.dnsmgr.net> References: <201802220104.w1M14uHQ088614@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21.02.2018 20:04, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] >> Author: mav >> Date: Thu Feb 22 00:46:24 2018 >> New Revision: 329770 >> URL: https://svnweb.freebsd.org/changeset/base/329770 >> >> Log: >> 9035 zfs: this statement may fall through >> >> illumos/illumos-gate@46ac8fdfc5a1f9d8240c79a6ae5b2889cbe83553 >> >> Reviewed by: Yuri Pankov <yuripv@yuripv.net> >> Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk> >> Reviewed by: Matthew Ahrens <mahrens@delphix.com> >> Approved by: Dan McDonald <danmcd@joyent.com> >> Author: Toomas Soome <tsoome@me.com> >> >> Modified: >> vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lgc.c >> vendor-sys/illumos/dist/uts/common/fs/zfs/lua/llex.c >> vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lstrlib.c >> vendor-sys/illumos/dist/uts/common/fs/zfs/lua/ltable.c >> >> Modified: vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lgc.c >> ============================================================================== >> --- vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lgc.c Thu Feb 22 00:42:12 2018 (r329769) >> +++ vendor-sys/illumos/dist/uts/common/fs/zfs/lua/lgc.c Thu Feb 22 00:46:24 2018 (r329770) >> @@ -677,7 +677,7 @@ static void freeobj (lua_State *L, GCObject *o) { >> case LUA_TUSERDATA: luaM_freemem(L, o, sizeudata(gco2u(o))); break; >> case LUA_TSHRSTR: >> G(L)->strt.nuse--; >> - /* go through */ >> + /* FALLTHROUGH */ >> case LUA_TLNGSTR: { >> luaM_freemem(L, o, sizestring(gco2ts(o))); >> break; >> >> Modified: vendor-sys/illumos/dist/uts/common/fs/zfs/lua/llex.c >> ============================================================================== >> --- vendor-sys/illumos/dist/uts/common/fs/zfs/lua/llex.c Thu Feb 22 00:42:12 2018 (r329769) >> +++ vendor-sys/illumos/dist/uts/common/fs/zfs/lua/llex.c Thu Feb 22 00:46:24 2018 (r329770) >> @@ -475,6 +475,7 @@ static int llex (LexState *ls, SemInfo *seminfo) { >> else if (!lisdigit(ls->current)) return '.'; >> /* else go through */ > ^^^^^^^^^^^^^^^^^^^^^^^ Wasnt this already marked, perhaps in the > wrong place with the wrong string? As I understand GCC 7 parses comments like that to decide whether generate warnings or not, but this informal text is out of his understanding. -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56dda9e2-e9ea-83b9-1e54-6569d478615a>