Date: Thu, 7 Jun 2001 17:35:12 -0400 (EDT) From: Andrew Gallatin <gallatin@cs.duke.edu> To: John Baldwin <jhb@FreeBSD.ORG> Cc: mjacob@feral.com, dfr@nlsystems.com, freebsd-alpha@FreeBSD.ORG Subject: RE: CFR: db_trace.c from NetBSD Message-ID: <15135.62352.926539.609146@grasshopper.cs.duke.edu> In-Reply-To: <XFMail.010607142439.jhb@FreeBSD.org> References: <15135.58046.974661.129491@grasshopper.cs.duke.edu> <XFMail.010607142439.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin writes: > > On 07-Jun-01 Andrew Gallatin wrote: > > > > I'd like to update our db_trace.c to use Ross Harvey's clever > > NetBSD traceback methods. > > > > The advantages are that we get a _lot_ more info. > > Yes please. The only comments I would make is that I would not remove the > check that bounds the count at 65535 for the default case (so that if you hit a > loop it will terminate at 65535 frames not 2 billion frames). Once this is Whoops, that was inadvertant. Thanks for pointing that out. > committed I will probably change the way the have_addr branch works to be > identical to that on the x86 (just trace pid, not trace tpid). This looks > great. Thanks! Thank Ross Harvey. I've updated the patch. I'll wait for more comments before comitting it (probably tomorrow am). Drew To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-alpha" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?15135.62352.926539.609146>