From owner-freebsd-ports@FreeBSD.ORG  Wed Jul 23 15:14:00 2008
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id ACCD51065673;
	Wed, 23 Jul 2008 15:14:00 +0000 (UTC)
	(envelope-from pgollucci@p6m7g8.com)
Received: from exhub015-1.exch015.msoutlookonline.net
	(exhub015-1.exch015.msoutlookonline.net [207.5.72.93])
	by mx1.freebsd.org (Postfix) with ESMTP id 9F9A78FC26;
	Wed, 23 Jul 2008 15:14:00 +0000 (UTC)
	(envelope-from pgollucci@p6m7g8.com)
Received: from philip.hq.rws (74.93.213.161) by smtpx15.msoutlookonline.net
	(207.5.72.103) with Microsoft SMTP Server (TLS) id 8.1.278.0;
	Wed, 23 Jul 2008 08:14:00 -0700
Message-ID: <48874AB6.6080604@p6m7g8.com>
Date: Wed, 23 Jul 2008 11:13:58 -0400
From: "Philip M. Gollucci" <pgollucci@p6m7g8.com>
Organization: P6 Web Applications Inc.
User-Agent: Thunderbird 2.0.0.12 (X11/20080414)
MIME-Version: 1.0
To: Florent Thoumie <flz@xbsd.org>
References: <1592773212-1216766394-cardhu_decombobulator_blackberry.rim.net-2001801074-@bxe056.bisx.produk.on.blackberry>	
	<a01628140807230314r247cd0b2h5da1138ca0a5b67@mail.gmail.com>	
	<F6E63544-13DD-4464-8EA5-C6D977176A0E@icelandic.net>	
	<a01628140807230508g340aac64x78eeeb8e9a637079@mail.gmail.com>	
	<20080723151212.18dfb88d@it.buh.tecnik93.com>
	<a01628140807230806v1706061aqd15d5825d6dbbb1@mail.gmail.com>
In-Reply-To: <a01628140807230806v1706061aqd15d5825d6dbbb1@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: ports@freebsd.org, Olafur Osvaldsson <osvaldsson@icelandic.net>,
	pgollucci@freebsd.org, Ion-Mihai Tetcu <itetcu@freebsd.org>,
	araujo@freebsd.org
Subject: Re: ports/125625: [PATCH] dns/nsd: USE_RC_SUBR != yes
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Jul 2008 15:14:00 -0000

Florent Thoumie wrote:
> On Wed, Jul 23, 2008 at 1:12 PM, Ion-Mihai Tetcu <itetcu@freebsd.org> wrote:
>> On Wed, 23 Jul 2008 13:08:03 +0100
>> "Florent Thoumie" <flz@xbsd.org> wrote:
>>
>>> On Wed, Jul 23, 2008 at 12:30 PM, Olafur Osvaldsson
>>> <osvaldsson@icelandic.net> wrote:
>>>> This is something the PR responsible introduced in his original
>>>> patch...
>>> It's still present in your version. Anyway, I'm not blaming anyone,
>>> just pointing out what I think is a mistake.
>> So this is not for the user but for the port?
>>
>> I'll do a swap on the tree for it, because I'm sure there are more
>> ports doing something like:
>> .ifndef(NO_INSTALL_MANPAGES)
>> ......
>> .endif
I was talking to itectu@ about this, and figured it would be better in 
Mk/bsd.port.mk.


> The general rule of thumb is: if it doesn't begin with WITH_ or
> WITHOUT_, it's not user-settable. NO_INSTALL_MANPAGES is used for
> ports using imake that don't understand the install.man target.
/me thought that was the USE_ vs WITH(OUT)?_ difference.

NO* is supposed to be user settable right ?

> 
> Now of course there are exceptions (usually for no good reason IMHO).
> The likes of NOPORTDOCS/NOPORTEXAMPLES/... could be changed to
> WITHOUT_DOCS/WITHOUT_EXAMPLES, it's just waiting for somebody to do
> the work.
Heh, maybe, I kind of feel like it will get reject as a style(9) change.

I'm all for it though, not saying I'm going to do it though.