Date: Mon, 4 Jan 2016 14:45:49 -0800 From: NGie Cooper <yaneurabeya@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: Garrett Cooper <ngie@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r293112 - head/sys/dev/ixl Message-ID: <CAGHfRMB0QGgiuoWm3CkiUReYqstA4pccKBp8g9gMW2zE=J7Ckw@mail.gmail.com> In-Reply-To: <1740114.0GzEsp8E6P@ralph.baldwin.cx> References: <201601031809.u03I9lNJ091471@repo.freebsd.org> <1740114.0GzEsp8E6P@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 3, 2016 at 2:23 PM, John Baldwin <jhb@freebsd.org> wrote: ... > FWIW, it is probably simpler to do something like this in an ixl header instead: > > #if __FreeBSD_version <= 1100022 > #define if_getdrvflags(ifp) (ifp)->if_drv_flags > #endif > > In the past when the Intel drivers have used compat shims they have preferred this > method (defining compat macros for "new" APIs on old OS versions) instead of using > #ifdef's in the code itself. You're right. What I did was incredibly ugly and only fixes one potential instance (of which more might appear later).. I'll send out a CR moving the definition to a header file and commit the change. Thanks! -NGie
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMB0QGgiuoWm3CkiUReYqstA4pccKBp8g9gMW2zE=J7Ckw>