From owner-svn-src-head@freebsd.org  Mon Jan  4 22:45:51 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 71150A61ABB;
 Mon,  4 Jan 2016 22:45:51 +0000 (UTC)
 (envelope-from yaneurabeya@gmail.com)
Received: from mail-lb0-x241.google.com (mail-lb0-x241.google.com
 [IPv6:2a00:1450:4010:c04::241])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id E9DA51811;
 Mon,  4 Jan 2016 22:45:50 +0000 (UTC)
 (envelope-from yaneurabeya@gmail.com)
Received: by mail-lb0-x241.google.com with SMTP id bc4so10017277lbc.0;
 Mon, 04 Jan 2016 14:45:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=MVMc3TkZz0Ls/AnfSP4cLaaPBGvW07/3q8qeSA8oUB0=;
 b=vHW4cJcvk8LvkxtZMO4gVc2OWDbPv//VKv+scGCk2x8d4iA9lcwN6EQM8Mbc9dPXi5
 hV/NeCwMm9v53ndT+/1H9u95JNEnsGPOLwnZs09+3fvK1uduCGuxQeXMAxRelGPa0NW6
 SzCgbuIZatgrsGw5fBnfNT77liNvv/WLoLrud5IClXL7ZXrA2noySJ2uQvb94owTlHpK
 l/BTAN181UjbCpW86ovqeIgi5LA3XF3I4RmIaWt3E3cKR0Hq29FiSM/yX83y6eUCdtC/
 Mt65Bw66owurzjKfYaPPqIfD3yMhL2u9dIwonZYGGCXreG7ga8FuqhEk05cccHn9C6xl
 1YYA==
MIME-Version: 1.0
X-Received: by 10.112.97.176 with SMTP id eb16mr32893730lbb.138.1451947549052; 
 Mon, 04 Jan 2016 14:45:49 -0800 (PST)
Received: by 10.112.160.133 with HTTP; Mon, 4 Jan 2016 14:45:49 -0800 (PST)
In-Reply-To: <1740114.0GzEsp8E6P@ralph.baldwin.cx>
References: <201601031809.u03I9lNJ091471@repo.freebsd.org>
 <1740114.0GzEsp8E6P@ralph.baldwin.cx>
Date: Mon, 4 Jan 2016 14:45:49 -0800
Message-ID: <CAGHfRMB0QGgiuoWm3CkiUReYqstA4pccKBp8g9gMW2zE=J7Ckw@mail.gmail.com>
Subject: Re: svn commit: r293112 - head/sys/dev/ixl
From: NGie Cooper <yaneurabeya@gmail.com>
To: John Baldwin <jhb@freebsd.org>
Cc: Garrett Cooper <ngie@freebsd.org>, 
 "src-committers@freebsd.org" <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jan 2016 22:45:51 -0000

On Sun, Jan 3, 2016 at 2:23 PM, John Baldwin <jhb@freebsd.org> wrote:

...

> FWIW, it is probably simpler to do something like this in an ixl header instead:
>
> #if __FreeBSD_version <= 1100022
> #define if_getdrvflags(ifp)     (ifp)->if_drv_flags
> #endif
>
> In the past when the Intel drivers have used compat shims they have preferred this
> method (defining compat macros for "new" APIs on old OS versions) instead of using
> #ifdef's in the code itself.

You're right. What I did was incredibly ugly and only fixes one
potential instance (of which more might appear later).. I'll send out
a CR moving the definition to a header file and commit the change.
Thanks!
-NGie