Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 2 Nov 2018 14:17:35 +0000 (UTC)
From:      Kurt Jaeger <pi@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r483810 - in head/mail/mailman: . files
Message-ID:  <201811021417.wA2EHZRG046603@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: pi
Date: Fri Nov  2 14:17:35 2018
New Revision: 483810
URL: https://svnweb.freebsd.org/changeset/ports/483810

Log:
  mail/mailman: add OPTION to not send passwords in the monthly mails
  
  - this option is now on by default
  
  PR:		231879
  Reported by:	several users
  Approved by:	mandree
  Obtained from:	https://mail.python.org/pipermail/mailman-users/2016-April/080746.html
  MFH:		2018Q4

Added:
  head/mail/mailman/files/extra-patch-mailpasswds   (contents, props changed)
Modified:
  head/mail/mailman/Makefile

Modified: head/mail/mailman/Makefile
==============================================================================
--- head/mail/mailman/Makefile	Fri Nov  2 14:09:45 2018	(r483809)
+++ head/mail/mailman/Makefile	Fri Nov  2 14:17:35 2018	(r483810)
@@ -3,7 +3,7 @@
 
 PORTNAME=	mailman
 DISTVERSION=	2.1.29
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	mail
 MASTER_SITES=	GNU \
 		SF/${PORTNAME}/Mailman%202.1%20%28stable%29/${PORTVERSION} \
@@ -71,8 +71,8 @@ PORTDOCS=	ACKNOWLEDGMENTS BUGS FAQ INSTALL NEWS README
 
 OPTIONS_SINGLE=	MTA
 OPTIONS_SINGLE_MTA=	COURIER EXIM4 OPENSMTPD POSTFIX SENDMAIL
-OPTIONS_DEFINE=	HTDIG NAMAZU2 NLS DOCS
-OPTIONS_DEFAULT=	SENDMAIL
+OPTIONS_DEFINE=	HTDIG NAMAZU2 NOMAILPWD NLS DOCS
+OPTIONS_DEFAULT=	SENDMAIL NOMAILPWD
 COURIER_DESC=	for use with courier
 EXIM4_DESC=	for use with exim4
 OPENSMTPD_DESC=	for use with opensmtpd - EXPERIMENTAL -
@@ -80,6 +80,7 @@ POSTFIX_DESC=	for use with postfix
 SENDMAIL_DESC=	for use with sendmail
 HTDIG_DESC=	- EXPERIMENTAL - htdig integration patches
 NAMAZU2_DESC=	Make private archives searchable with namazu2
+NOMAILPWD_DESC=	Elide plaintext passwords from monthly reminders
 MTA_DESC=	Integrate with which MTA?
 
 .include <bsd.port.options.mk>
@@ -140,6 +141,10 @@ PLIST_SUB+=	SUB_HTDIG="@comment "
 .if ${PORT_OPTIONS:MNAMAZU2}
 RUN_DEPENDS+=	mknmz:databases/namazu2
 EXTRA_PATCHES+=	${FILESDIR}/extra-patch-Mailman-Cgi-private.py
+.endif
+
+.if ${PORT_OPTIONS:MNOMAILPWD}
+EXTRA_PATCHES+=	${FILESDIR}/extra-patch-mailpasswds
 .endif
 
 BUILD_DEPENDS+=	${PYTHON_PKGNAMEPREFIX}dnspython>=0:dns/py-dnspython@${PY_FLAVOR}

Added: head/mail/mailman/files/extra-patch-mailpasswds
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/mail/mailman/files/extra-patch-mailpasswds	Fri Nov  2 14:17:35 2018	(r483810)
@@ -0,0 +1,22 @@
+--- cron/mailpasswds.orig	2018-07-25 00:01:28.000000000 +0200
++++ cron/mailpasswds	2018-10-03 11:00:40.137699000 +0200
+@@ -148,17 +148,8 @@
+                 if mlist.getMemberOption(member,
+                                          mm_cfg.SuppressPasswordReminder):
+                     continue
+-                # Group by the lower-cased address, since Mailman always
+-                # treates person@dom.ain the same as PERSON@dom.ain.
+-                try:
+-                    password = mlist.getMemberPassword(member)
+-                except Errors.NotAMemberError:
+-                    # Here's a member with no passwords, which I think was
+-                    # possible in older versions of Mailman.  Log this and
+-                    # move on.
+-                    syslog('error', 'password-less member %s for list %s',
+-                           member, mlist.internal_name())
+-                    continue
++                # https://mail.python.org/pipermail/mailman-users/2016-April/080746.html
++                password = '****'
+                 optionsurl = mlist.GetOptionsURL(member)
+                 lang = mlist.getMemberLanguage(member)
+                 info = (listaddr, password, optionsurl, lang)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201811021417.wA2EHZRG046603>