From owner-cvs-all Mon Dec 16 12:58:51 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ED64D37B401; Mon, 16 Dec 2002 12:58:49 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id A900443EC2; Mon, 16 Dec 2002 12:58:49 -0800 (PST) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 83F48AE1C1; Mon, 16 Dec 2002 12:58:49 -0800 (PST) Date: Mon, 16 Dec 2002 12:58:49 -0800 From: Alfred Perlstein To: Matt Dillon Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm.h src/sys/kern imgact_elf.c src/libexec/rtld-elf map_object.c Message-ID: <20021216205849.GV23663@elvis.mu.org> References: <200212161924.gBGJOhSb048310@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200212161924.gBGJOhSb048310@repoman.freebsd.org> User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Matt Dillon [021216 11:24] wrote: > dillon 2002/12/16 11:24:43 PST > > Modified files: > sys/vm vm.h > sys/kern imgact_elf.c > libexec/rtld-elf map_object.c > Log: > Change the way ELF coredumps are handled. Instead of unconditionally > skipping read-only pages, which can result in valuable non-text-related > data not getting dumped, the ELF loader and the dynamic loader now mark > read-only text pages NOCORE and the coredump code only checks (primarily) for > complete inaccessibility of the page or NOCORE being set. > > Certain applications which map large amounts of read-only data will > produce much larger cores. A new sysctl has been added, > debug.elf_legacy_coredump, which will revert to the old behavior. > > This commit represents collaborative work by all parties involved. > The PR contains a program demonstrating the problem. Wouldn't it make sense to automagically OR in NOCORE when calling mmap for readonly, but when madvise is called _then_ turn off NOCORE? -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message