From owner-freebsd-x11@freebsd.org Sat Aug 17 01:14:49 2019 Return-Path: Delivered-To: freebsd-x11@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 87EC4B64FB for ; Sat, 17 Aug 2019 01:14:49 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 469Mfx2PMgz3HnW for ; Sat, 17 Aug 2019 01:14:49 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mailman.nyi.freebsd.org (Postfix) id 524BAB64F3; Sat, 17 Aug 2019 01:14:49 +0000 (UTC) Delivered-To: x11@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 520C0B64F2 for ; Sat, 17 Aug 2019 01:14:49 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 469Mfw1rw0z3HnR for ; Sat, 17 Aug 2019 01:14:48 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x744.google.com with SMTP id u190so6258426qkh.5 for ; Fri, 16 Aug 2019 18:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s481+qQgLeCjvbjQ5Aw+WgkK/JuZ/6+oufFbcbn7q9o=; b=EsrSyhn36/VodwNd6f9bWu8fN5ZWTJ9VEIjMckSveG9S6G43hL9I+e/KBnwIzVrTk+ sHe/02TpURq33ZG8VM3YsGfVvKlJkbDMg4sDPpX1uj6WnJdyNopI2WlDHWarcf6I2Ini nhPs5FM2mz2Rior2P5z6+8jpDlIJWeDRkd5q/yTan4ZHHXjWL5eKCRJvReZyyevtPk40 CAnkkVakdmx4ThWUKHtyc7vQM6I3SNaY9YSZfaGoqvX9RP7JUnV8E4+DhSh8WsRLmQba 6LSQYCrKCWg9Vsd0XVin3nKVRvqVQhmGrkkoCTOty62bAyvwsio+JE8NLBG8xSdepjMy GcPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s481+qQgLeCjvbjQ5Aw+WgkK/JuZ/6+oufFbcbn7q9o=; b=NY1TUBmklLTNqHJClCNleo1WDsbgVFCtFm3C6AFIChb2w/mZDIbbucMd7CV6jsGhf1 cLNEz91YvGODBo1KHqfZAF7mxoJbzCPP9rcNdHpvjZcs0MMvz5tgceW0mWB3dqCB35Sb qG/Z6R8PRre0sQ9Q7yFT+C7ekFKPdgkRdKL55kfiQSYW40qYiVooG4R2ygMZXQbBYseB PY5ikrLjsec4Rxdj5OOIFiQh3/7AqPhvaU5dEATtLQMp3nNBvV3gMvr1waWWhX/EKTzH H4smBOWRSlYn+BI2QfD640D0SRyX1iOn8ejjwStj34ZGgEB9OPgfuoky+gjEFmViSAA9 6nhQ== X-Gm-Message-State: APjAAAXSkXPBhuJZZTyy7basT4W+syEAzmZBAbv8kU2HSFbuFODP0WBJ InjovXWlRBsKoDM3v+YCq4C9Ep2I9/jeuIt6pjsuYA== X-Google-Smtp-Source: APXvYqySBnSFsKPsiXooFY+qxSk3soMzElR8gjFEUlTFj/oOhmWlWkaecxRGhpiagjZKxH4Sb7il1lDOmstbP+rD1Z0= X-Received: by 2002:a05:620a:621:: with SMTP id 1mr8834992qkv.380.1566004486919; Fri, 16 Aug 2019 18:14:46 -0700 (PDT) MIME-Version: 1.0 References: <201908162151.x7GLpMqf032597@gndrsh.dnsmgr.net> <0aabe497-c0c1-c671-d336-4ede3f3cf931@FreeBSD.org> In-Reply-To: <0aabe497-c0c1-c671-d336-4ede3f3cf931@FreeBSD.org> From: Warner Losh Date: Fri, 16 Aug 2019 19:14:35 -0600 Message-ID: Subject: Re: HEADSUP: drm-current-kmod now installs sources To: John Baldwin Cc: "Rodney W. Grimes" , Daniel Eischen , FreeBSD Current , x11@freebsd.org, FreeBSD Current X-Rspamd-Queue-Id: 469Mfw1rw0z3HnR X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=EsrSyhn3; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::744) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.56 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[x11@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.99)[-0.985,0]; RCVD_IN_DNSWL_NONE(0.00)[4.4.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-0.58)[ip: (2.50), ipnet: 2607:f8b0::/32(-2.96), asn: 15169(-2.38), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Aug 2019 01:14:49 -0000 On Fri, Aug 16, 2019 at 6:37 PM John Baldwin wrote: > On 8/16/19 2:51 PM, Rodney W. Grimes wrote: > >> On 8/14/19 3:40 PM, Daniel Eischen wrote: > >>> I've lost the original thread, but would the sources in > /usr/local/sys/modules get built regardless of what MAKEOBJDIRPREFIX is? > And, now that sources may be installed by a port, what is the method for > _just_ updating the sources? Why do I even need to build and install the > port? Personally, I would just rather have the drm-kmod sources just > imported into base and maintained there. If I have 2 or more different > checked out base src trees, how do I get the correct drm-kmod to go with > them if there is only one /usr/local/sys/modules? Do I need multiple port > trees just to pull in out of tree module sources? > >> > >> In some ways, installing sources for DRM is a compromise for the fact > that we > >> can't have DRM in the base source anymore (for various reasons). > However, > >> virtualbox is also probably in that camp as well. > > > > I applaud this effort to provide a source compile mode for DRM, > > but I think it has come up a bit short on execution with numorious > > problems sited. > > Do you have a reported problem vs a theoretical problem? The > only reported problem I've seen is that LOCAL_MODULES="" doesn't > work. That and Cy reported a build error from a recent commit to > head due to LOCAL_MODULES working as intended. > And once it's working like it is supposed too, you can override it on a per-tree basis. But it needs to be on by default to avoid POLA. > > I too am not real happy that /usr/local/src is going to get > > automatically invoked from my some odd 10+ src trees that > > are of various WIP's. I need a way to easily disable this > > both on a global scale, and on a per src tree way. > > Modulo the LOCAL_MODULES="" not working (you have to just use > LOCAL_MODULES=) this already exists. You can set it in > /etc/src.conf, in a kernel config, or on the command line. > You can also per-tree settings on a src.conf if you want. Nanobsd overrides /etc/src.conf and others to set per-build defaults that are reproducible w/o host contamination, for example. We have half a dozen mechanisms for managing per-tree settings. > > Rather than a default to on with an opt out mechanism perhaps > > while we gain experience change this to a default to off with > > an opt in mechanism? > > It's head, not stable. We can't gain experience with something > that isn't turned Turned off by default violates POLA for people that pkg install the drm stuff. They expect it to just work, even if they rebuild the kernel. So for at least the non-cross-build cases, it should be on by default. People with special needs, like 10 trees, will have to tweak their defaults. We cannot set the defaults based on that. Most developers have one or two trees and can easily manage when they are building stuff for other systems, jail images, etc on a case by case basis. Warner