From owner-svn-ports-all@freebsd.org Fri Feb 16 16:42:20 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2BF25F23B26; Fri, 16 Feb 2018 16:42:20 +0000 (UTC) (envelope-from tijl@freebsd.org) Received: from mailrelay114.isp.belgacom.be (mailrelay114.isp.belgacom.be [195.238.20.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "relay.skynet.be", Issuer "GlobalSign Organization Validation CA - SHA256 - G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5313D84C4D; Fri, 16 Feb 2018 16:42:19 +0000 (UTC) (envelope-from tijl@freebsd.org) X-Belgacom-Dynamic: yes IronPort-PHdr: =?us-ascii?q?9a23=3A3kVvRxyHLppyxJnXCy+O+j09IxM/srCxBDY+r6Qd?= =?us-ascii?q?2uMQIJqq85mqBkHD//Il1AaPAd2Araocw8Pt8InYEVQa5piAtH1QOLdtbDQizf?= =?us-ascii?q?ssogo7HcSeAlf6JvO5JwYzHcBFSUM3tyrjaRsdF8nxfUDdrWOv5jAOBBr/KRB1?= =?us-ascii?q?JuPoEYLOksi7ze+/94HdbglSmDaxfa55IQmrownWqsQYm5ZpJLwryhvOrHtIeu?= =?us-ascii?q?BWyn1tKFmOgRvy5dq+8YB6/ShItP0v68BPUaPhf6QlVrNYFygpM3o05MLwqxbO?= =?us-ascii?q?SxaE62YGXWUXlhpIBBXF7A3/U5zsvCb2qvZx1S+HNsDtU7s6RSqt4LtqSB/wiS?= =?us-ascii?q?cIKTg58H3MisdtiK5XuQ+tqwBjz4LRZoybKed+cbjGfdMGWGFBQNxeVzZaAoih?= =?us-ascii?q?a4cCD/YNMeNeooLgpVUBsAG+CBGiCu3v1DFGm3z40q800+suDQ7I0xctH84MvX?= =?us-ascii?q?jIsNn5KLseXf6zwaLVzTvDdfRW2TLl5YbWcxAho/WMVq9ufMrWzkkvDB3KjlCK?= =?us-ascii?q?pozjJDOey+MAs3Sa7+piUeKikG4pqxtvrTex28oil4fHipgSylDe+iV02YA4Ls?= =?us-ascii?q?C7Rk5jedOpE4ZcuzuEO4Z5Q84uWXxktSg0x7EcpJK2cicHxZI6zBDFcfOHaZKH?= =?us-ascii?q?4hf7WeaUJjd3mWxqdaqkhxa37Uig0ur8VtSo0FpSripKjN3MtncV2hzQ8MeHTv?= =?us-ascii?q?p9/kK/1jaV0ADf8P1EIUE2larfMZIu3rkwlp0IsUvdGy/5gkP2jLSMekUj4Oio?= =?us-ascii?q?5PzrYrTgppCCK495kgLzPrk0lsChDuk1MxICU3WV9OmyzrHv4EP0TbpSgv0ziK?= =?us-ascii?q?bZsZTaJcoBpq6+Bg9Yypoj6xe9Dzeiy9kYk2MHI0xbdx2clIjmJkvCIPfiDfew?= =?us-ascii?q?m1isiitkx+jaPr39BZXANmPDkKnnfbpk805czxAzzcxE555NCrEOPuj8VVLqud?= =?us-ascii?q?zWFB82LRK7zP38CNpgzI8eXniPAqCBOqPIrVCI/v4vI/WLZIINozb9Nf4l6+f2?= =?us-ascii?q?jX8+g18dYbKp0YINZ3C8GvRrOEuZYWDyjdgfCmgKpRcxQPbtiF2YXj5Zf2yyUL?= =?us-ascii?q?4k5jEnFIKmCp/ORpiqgLybwCe7BYRaaXxBClCJFHfodpmEW+sSZyKIOc9siTIE?= =?us-ascii?q?VaK/RIA/zh6urxL1x6BgLurO9S0SrYjj28Rt5+3PiREy8iR5D8qD3GGJUm55hW?= =?us-ascii?q?0IRyUo069hukN90UqM3bJ/g/xCGtwAr89OByIzL52U4eF+B93oElbPc9OFYHi8?= =?us-ascii?q?T9iMOh13Scg+lYwgeUF4TumjjBSL9C2tGLIQnrqQTMgo86DY91brKstX8FqA07?= =?us-ascii?q?Mu2Qp1CvBTPHGr0/YsvzPYAJTExgDEz6s=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2DPQACkCIda/4aF9lFcHAEBAQQBAQoBA?= =?us-ascii?q?YNPVoEAFROObY0QAQGCATIBZJhfhUUCgkVZFAECAQEBAQEBAgFqKEIQAYFlJIJ?= =?us-ascii?q?IAQU6HCMQCw4KCSUPKh4GE4olr3CIf4ITAQEBAQEFAQEBAQEjhQeIXzaFI4V8B?= =?us-ascii?q?YpmiWKPbQmVfYEGk09ImRM2IoFRTTAIgn2CVByCB0A3hVqITAEBAQ?= X-IPAS-Result: =?us-ascii?q?A2DPQACkCIda/4aF9lFcHAEBAQQBAQoBAYNPVoEAFROObY0?= =?us-ascii?q?QAQGCATIBZJhfhUUCgkVZFAECAQEBAQEBAgFqKEIQAYFlJIJIAQU6HCMQCw4KC?= =?us-ascii?q?SUPKh4GE4olr3CIf4ITAQEBAQEFAQEBAQEjhQeIXzaFI4V8BYpmiWKPbQmVfYE?= =?us-ascii?q?Gk09ImRM2IoFRTTAIgn2CVByCB0A3hVqITAEBAQ?= Received: from 134.133-246-81.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([81.246.133.134]) by relay.skynet.be with ESMTP; 16 Feb 2018 17:41:07 +0100 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.15.2/8.15.2) with ESMTP id w1GGf6UR080594; Fri, 16 Feb 2018 17:41:07 +0100 (CET) (envelope-from tijl@FreeBSD.org) Date: Fri, 16 Feb 2018 17:41:06 +0100 From: Tijl Coosemans To: Mark Felder Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r461746 - head/security/ca_root_nss Message-ID: <20180216174106.125d61af@kalimero.tijl.coosemans.org> In-Reply-To: <1518795735.3761657.1273209560.03AB7B50@webmail.messagingengine.com> References: <201802132045.w1DKjdOQ093642@repo.freebsd.org> <20180214141840.583d247a@kalimero.tijl.coosemans.org> <1518795735.3761657.1273209560.03AB7B50@webmail.messagingengine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Feb 2018 16:42:20 -0000 On Fri, 16 Feb 2018 09:42:15 -0600 Mark Felder wrote: > On Wed, Feb 14, 2018, at 07:18, Tijl Coosemans wrote: >> On Tue, 13 Feb 2018 20:45:39 +0000 (UTC) Mark Felder wrote: >>> Modified: head/security/ca_root_nss/pkg-plist >>> ============================================================================== >>> --- head/security/ca_root_nss/pkg-plist Tue Feb 13 20:25:50 2018 (r461745) >>> +++ head/security/ca_root_nss/pkg-plist Tue Feb 13 20:45:38 2018 (r461746) >>> @@ -3,3 +3,4 @@ >>> @sample openssl/cert.pem.sample >>> %%ETCSYMLINK%%/etc/ssl/cert.pem >>> %%ETCSYMLINK%%@dir /etc/ssl >>> +@postexec [ -x %%LOCALBASE%%/bin/cert-sync ] && %%LOCALBASE%%/bin/cert-sync --quiet %%PREFIX%%/share/certs/ca-root-nss.crt >> >> This command returns an error if the executable doesn't exist. You >> should invert the logic: >> >> @postexec [ ! -x %%LOCALBASE%%/bin/cert-sync ] || %%LOCALBASE%%/bin/ >> cert-sync --quiet %%PREFIX%%/share/certs/ca-root-nss.crt > > What did the error look like? I wasn't seeing anything in my testport > runs. I intentionally reversed the logic from the original submitter for > readability and now feel like a fool. :-) Installing ca_root_nss-3.35_1... pkg-static: POST-INSTALL script failed Logically, "condition && command" is a conjunction (returns true if both sides are true) while "!condition || command" is an implication like "if condition then command". If-then may be more readable though. I changed -x to -e because I think it's informative to report an error if the command exists but isn't executable.